Bug fix: wrong link when pressing enter #4863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Blargian is attempting to deploy a commit to the ClickHouse Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
…into fix_on_enter
dhtclk
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The issue was that Algolia returns URLs as relative paths (e.g., /operations/settings/settings#...) without the /docs prefix. When clicking on search results, the Docusaurus Link component automatically prepends the baseUrl (/docs/), so clicking works correctly. However, when pressing Enter, DocSearch uses the navigator.navigate() function which calls history.push() directly, and history.push() expects the full path including the baseUrl.
Added logic to the navigator to prepend /docs to relative URLs before passing them to history.push(). This ensures Enter key navigation works correctly, matching the behavior of clicking on search results.
Checklist