Skip to content

Commit 01f47f3

Browse files
authored
Merge pull request #2326 from ClickHouse/small-meta-tweak
Quick Update to DatabaseMetaDataImpl.java
2 parents df339eb + 26dd293 commit 01f47f3

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1087,62 +1087,52 @@ public boolean supportsResultSetConcurrency(int type, int concurrency) throws SQ
10871087

10881088
@Override
10891089
public boolean ownUpdatesAreVisible(int type) throws SQLException {
1090-
// TODO: should be true
10911090
return false;
10921091
}
10931092

10941093
@Override
10951094
public boolean ownDeletesAreVisible(int type) throws SQLException {
1096-
// TODO: should be true
10971095
return false;
10981096
}
10991097

11001098
@Override
11011099
public boolean ownInsertsAreVisible(int type) throws SQLException {
1102-
// TODO: should be true
11031100
return false;
11041101
}
11051102

11061103
@Override
11071104
public boolean othersUpdatesAreVisible(int type) throws SQLException {
1108-
// TODO: should be checked
11091105
return false;
11101106
}
11111107

11121108
@Override
11131109
public boolean othersDeletesAreVisible(int type) throws SQLException {
1114-
// TODO: should be checked
11151110
return false;
11161111
}
11171112

11181113
@Override
11191114
public boolean othersInsertsAreVisible(int type) throws SQLException {
1120-
// TODO: should be checked
11211115
return false;
11221116
}
11231117

11241118
@Override
11251119
public boolean updatesAreDetected(int type) throws SQLException {
1126-
// TODO: should be checked
11271120
return false;
11281121
}
11291122

11301123
@Override
11311124
public boolean deletesAreDetected(int type) throws SQLException {
1132-
// TODO: should be checked
11331125
return false;
11341126
}
11351127

11361128
@Override
11371129
public boolean insertsAreDetected(int type) throws SQLException {
1138-
// TODO: should be checked
11391130
return false;
11401131
}
11411132

11421133
@Override
11431134
public boolean supportsBatchUpdates() throws SQLException {
1144-
// TODO: should be checked
1145-
return false;
1135+
return true;
11461136
}
11471137

11481138
@Override

0 commit comments

Comments
 (0)