Skip to content

Commit 083845b

Browse files
author
Paultagoras
committed
Adjusting to just Timezone type
1 parent 56819cc commit 083845b

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/JdbcUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ private static Map<ClickHouseDataType, SQLType> generateTypeMap() {
4646
map.put(ClickHouseDataType.Enum16, JDBCType.VARCHAR);
4747
map.put(ClickHouseDataType.Date, JDBCType.DATE);
4848
map.put(ClickHouseDataType.Date32, JDBCType.DATE);
49-
map.put(ClickHouseDataType.DateTime, JDBCType.TIMESTAMP_WITH_TIMEZONE);
50-
map.put(ClickHouseDataType.DateTime32, JDBCType.TIMESTAMP_WITH_TIMEZONE);
51-
map.put(ClickHouseDataType.DateTime64, JDBCType.TIMESTAMP_WITH_TIMEZONE);
49+
map.put(ClickHouseDataType.DateTime, JDBCType.TIMESTAMP);
50+
map.put(ClickHouseDataType.DateTime32, JDBCType.TIMESTAMP);
51+
map.put(ClickHouseDataType.DateTime64, JDBCType.TIMESTAMP);
5252
map.put(ClickHouseDataType.Array, JDBCType.ARRAY);
5353
map.put(ClickHouseDataType.Nested, JDBCType.ARRAY);
5454
map.put(ClickHouseDataType.Map, JDBCType.JAVA_OBJECT);

jdbc-v2/src/test/java/com/clickhouse/jdbc/DataTypeTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -899,28 +899,28 @@ public void testTypeConversions() throws Exception {
899899
assertEquals(rs.getString(5), "2024-12-01T12:34:56Z[UTC]");
900900
assertEquals(rs.getObject(5, LocalDateTime.class), LocalDateTime.of(2024, 12, 1, 12, 34, 56));
901901
assertEquals(rs.getObject(5, ZonedDateTime.class), ZonedDateTime.of(2024, 12, 1, 12, 34, 56, 0, ZoneId.of("UTC")));
902-
assertEquals(String.valueOf(rs.getObject(5, new HashMap<String, Class<?>>(){{put(JDBCType.TIMESTAMP_WITH_TIMEZONE.getName(), LocalDateTime.class);}})), "2024-12-01T12:34:56");
902+
assertEquals(String.valueOf(rs.getObject(5, new HashMap<String, Class<?>>(){{put(JDBCType.TIMESTAMP.getName(), LocalDateTime.class);}})), "2024-12-01T12:34:56");
903903

904904
assertEquals(rs.getTimestamp(6), Timestamp.valueOf("2024-12-01 12:34:56.789"));
905905
assertTrue(rs.getObject(6) instanceof Timestamp);
906906
assertEquals(rs.getObject(6), Timestamp.valueOf("2024-12-01 12:34:56.789"));
907907
assertEquals(rs.getString(6), "2024-12-01T12:34:56.789Z[UTC]");
908908
assertEquals(rs.getObject(6, LocalDateTime.class), LocalDateTime.of(2024, 12, 1, 12, 34, 56, 789000000));
909-
assertEquals(String.valueOf(rs.getObject(6, new HashMap<String, Class<?>>(){{put(JDBCType.TIMESTAMP_WITH_TIMEZONE.getName(), LocalDateTime.class);}})), "2024-12-01T12:34:56.789");
909+
assertEquals(String.valueOf(rs.getObject(6, new HashMap<String, Class<?>>(){{put(JDBCType.TIMESTAMP.getName(), LocalDateTime.class);}})), "2024-12-01T12:34:56.789");
910910

911911
assertEquals(rs.getTimestamp(7), Timestamp.valueOf("2024-12-01 12:34:56.789789"));
912912
assertTrue(rs.getObject(7) instanceof Timestamp);
913913
assertEquals(rs.getObject(7), Timestamp.valueOf("2024-12-01 12:34:56.789789"));
914914
assertEquals(rs.getString(7), "2024-12-01T12:34:56.789789Z[UTC]");
915915
assertEquals(rs.getObject(7, LocalDateTime.class), LocalDateTime.of(2024, 12, 1, 12, 34, 56, 789789000));
916-
assertEquals(String.valueOf(rs.getObject(7, new HashMap<String, Class<?>>(){{put(JDBCType.TIMESTAMP_WITH_TIMEZONE.getName(), OffsetDateTime.class);}})), "2024-12-01T12:34:56.789789Z");
916+
assertEquals(String.valueOf(rs.getObject(7, new HashMap<String, Class<?>>(){{put(JDBCType.TIMESTAMP.getName(), OffsetDateTime.class);}})), "2024-12-01T12:34:56.789789Z");
917917

918918
assertEquals(rs.getTimestamp(8), Timestamp.valueOf("2024-12-01 12:34:56.789789789"));
919919
assertTrue(rs.getObject(8) instanceof Timestamp);
920920
assertEquals(rs.getObject(8), Timestamp.valueOf("2024-12-01 12:34:56.789789789"));
921921
assertEquals(rs.getString(8), "2024-12-01T12:34:56.789789789Z[UTC]");
922922
assertEquals(rs.getObject(8, LocalDateTime.class), LocalDateTime.of(2024, 12, 1, 12, 34, 56, 789789789));
923-
assertEquals(String.valueOf(rs.getObject(8, new HashMap<String, Class<?>>(){{put(JDBCType.TIMESTAMP_WITH_TIMEZONE.getName(), ZonedDateTime.class);}})), "2024-12-01T12:34:56.789789789Z[UTC]");
923+
assertEquals(String.valueOf(rs.getObject(8, new HashMap<String, Class<?>>(){{put(JDBCType.TIMESTAMP.getName(), ZonedDateTime.class);}})), "2024-12-01T12:34:56.789789789Z[UTC]");
924924
}
925925
}
926926
}

jdbc-v2/src/test/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public void testGetColumns() throws Exception {
4040
List<String> columnNames = Arrays.asList("id", "name", "float1", "fixed_string1", "decimal_1", "nullable_column", "date", "datetime");
4141
List<String> columnTypes = Arrays.asList("UInt64", "String", "Float32", "FixedString(10)", "Decimal(10, 2)", "Nullable(Decimal(5, 4))", "Date", "DateTime");
4242
List<Integer> columnSizes = Arrays.asList(8, 0, 4, 10, 10, 5, 2, 0);
43-
List<Integer> columnJDBCDataTypes = Arrays.asList(Types.BIGINT, Types.VARCHAR, Types.FLOAT, Types.CHAR, Types.DECIMAL, Types.DECIMAL, Types.DATE, Types.TIMESTAMP_WITH_TIMEZONE);
43+
List<Integer> columnJDBCDataTypes = Arrays.asList(Types.BIGINT, Types.VARCHAR, Types.FLOAT, Types.CHAR, Types.DECIMAL, Types.DECIMAL, Types.DATE, Types.TIMESTAMP);
4444
List<String> columnTypeNames = Arrays.asList("UInt64", "String", "Float32", "FixedString(10)", "Decimal(10, 2)", "Nullable(Decimal(5, 4))", "Date", "DateTime");
4545
List<Boolean> columnNullable = Arrays.asList(false, false, false, false, false, true, false, false);
4646
List<Integer> columnDecimalDigits = Arrays.asList(null, null, null, null, 2, 4, null, null);

jdbc-v2/src/test/java/com/clickhouse/jdbc/metadata/ResultSetMetaDataTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public void testGetColumnTypeDateAndTime() throws Exception {
9191
ResultSet rs = stmt.executeQuery("SELECT toDate('2021-01-01') AS a, toDateTime('2021-01-01 00:00:00') AS b");
9292
ResultSetMetaData rsmd = rs.getMetaData();
9393
assertEquals(rsmd.getColumnType(1), Types.DATE);
94-
assertEquals(rsmd.getColumnType(2), Types.TIMESTAMP_WITH_TIMEZONE);
94+
assertEquals(rsmd.getColumnType(2), Types.TIMESTAMP);
9595
}
9696
}
9797
}

0 commit comments

Comments
 (0)