Skip to content

Commit 0e59b6e

Browse files
committed
added version check to the test. fixed NPE getting operation timeout setting
1 parent 122fc96 commit 0e59b6e

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

client-v2/src/main/java/com/clickhouse/client/api/Client.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1980,7 +1980,7 @@ public Map<String, String> getConfiguration() {
19801980

19811981
/** Returns operation timeout in seconds */
19821982
protected int getOperationTimeout() {
1983-
return (int) configuration.get(ClientConfigProperties.MAX_EXECUTION_TIME.getKey());
1983+
return ClientConfigProperties.MAX_EXECUTION_TIME.getOrDefault(configuration);
19841984
}
19851985

19861986
/**

client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,8 @@ public CloseableHttpClient createHttpClient(boolean initSslContext, Map<String,
280280
soCfgBuilder.setSocksProxyAddress(new InetSocketAddress(proxyHost, proxyPort));
281281
}
282282

283-
if (ClientConfigProperties.HTTP_SAVE_COOKIES.getOrDefault(configuration)) {
283+
boolean disableCookies = !((Boolean)ClientConfigProperties.HTTP_SAVE_COOKIES.getOrDefault(configuration));
284+
if (disableCookies) {
284285
clientBuilder.disableCookieManagement();
285286
}
286287
SocketConfig socketConfig = soCfgBuilder.build();

jdbc-v2/src/test/java/com/clickhouse/jdbc/DataTypeTests.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.clickhouse.client.api.ClientConfigProperties;
44
import com.clickhouse.client.api.internal.ServerSettings;
5+
import com.clickhouse.data.ClickHouseVersion;
56
import com.clickhouse.data.Tuple;
67
import org.slf4j.Logger;
78
import org.slf4j.LoggerFactory;
@@ -1064,8 +1065,12 @@ public void testTupleTypeSimpleStatement() throws SQLException {
10641065

10651066

10661067

1067-
@Test
1068-
public void testJSONTypeSimpleStatement() throws SQLException {
1068+
@Test(groups = { "integration" })
1069+
public void testJSONWritingAsString() throws SQLException {
1070+
if (ClickHouseVersion.of(getServerVersion()).check("(,24.8]")) {
1071+
return; // JSON was introduced in 24.10
1072+
}
1073+
10691074
runQuery("CREATE TABLE test_json (order Int8, "
10701075
+ "json JSON"
10711076
+ ") ENGINE = MergeTree ORDER BY ()");

0 commit comments

Comments
 (0)