Skip to content

Commit 11206f1

Browse files
committed
fixed tests
1 parent 7d74e68 commit 11206f1

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaData.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -852,7 +852,6 @@ public ResultSet getColumns(String catalog, String schemaPattern, String tableNa
852852
"'NO' as IS_GENERATEDCOLUMN " +
853853
" FROM system.columns" +
854854
" WHERE database LIKE '" + (schemaPattern == null ? "%" : schemaPattern) + "'" +
855-
" AND database LIKE '" + (catalog == null ? "%" : catalog) + "'" +
856855
" AND table LIKE '" + (tableNamePattern == null ? "%" : tableNamePattern) + "'" +
857856
" AND name LIKE '" + (columnNamePattern == null ? "%" : columnNamePattern) + "'" +
858857
" ORDER BY TABLE_SCHEM, TABLE_NAME, ORDINAL_POSITION";

jdbc-v2/src/test/java/com/clickhouse/jdbc/JdbcIntegrationTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,7 @@ public Connection getJdbcConnection(Properties properties) throws SQLException {
3939
info.putAll(properties);
4040
}
4141

42-
if (isCloud()) {
43-
info.setProperty(ClientConfigProperties.DATABASE.getKey(), ClickHouseServerForTest.getDatabase());
44-
}
42+
info.setProperty(ClientConfigProperties.DATABASE.getKey(), ClickHouseServerForTest.getDatabase());
4543

4644
return new ConnectionImpl(getEndpointString(), info);
4745
//return DriverManager.getConnection(getEndpointString(), "default", ClickHouseServerForTest.getPassword());

jdbc-v2/src/test/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public void testGetColumns() throws Exception {
5454
conn.createStatement().execute(createTableStmt.toString());
5555

5656
DatabaseMetaData dbmd = conn.getMetaData();
57-
ResultSet rs = dbmd.getColumns(ClickHouseServerForTest.getDatabase(), null, tableName, null);
57+
ResultSet rs = dbmd.getColumns(null, ClickHouseServerForTest.getDatabase(), tableName, null);
5858

5959
int count = 0;
6060
while (rs.next()) {
@@ -194,8 +194,9 @@ public void testGetTableTypes() throws Exception {
194194
}
195195
}
196196

197-
@Test(groups = { "integration" })
197+
@Test(groups = { "integration" }, enabled = false)
198198
public void testGetColumnsWithEmptyCatalog() throws Exception {
199+
// test not relevant until catalogs are implemented
199200
try (Connection conn = getJdbcConnection()) {
200201
DatabaseMetaData dbmd = conn.getMetaData();
201202
ResultSet rs = dbmd.getColumns("", null, "numbers", null);

0 commit comments

Comments
 (0)