Addressing PR feedback

Author: Paultagoras

client-v2/src/main/java/com/clickhouse/client/api/Client.java

@@ -1,6 +1,7 @@
 package com.clickhouse.client.api;
 
 import com.clickhouse.client.*;
+import com.clickhouse.client.api.exception.ClientException;
 import com.clickhouse.client.api.insert.InsertResponse;
 import com.clickhouse.client.api.insert.InsertSettings;
 import com.clickhouse.client.api.insert.POJOSerializer;
@@ -242,7 +243,7 @@ public void register(Class<?> clazz, TableSchema schema) {
      */
     public InsertResponse insert(String tableName,
                                          List<Object> data,
-                                         InsertSettings settings) throws IOException, InvocationTargetException, IllegalAccessException, ExecutionException, InterruptedException {
+                                         InsertSettings settings) throws ClientException, IOException {
         if (data == null || data.isEmpty()) {
             throw new IllegalArgumentException("Data cannot be empty");
         }
@@ -274,7 +275,11 @@ public InsertResponse insert(String tableName,
         //Call the static .serialize method on the POJOSerializer for each object in the list
         for (Object obj : data) {
             for (POJOSerializer serializer : serializers) {
-                serializer.serialize(obj, stream);
+                try {
+                    serializer.serialize(obj, stream);
+                } catch (InvocationTargetException | IllegalAccessException | IOException  e) {
+                    throw new ClientException(e);
+                }
             }
         }
         long s3 = System.currentTimeMillis();
@@ -288,7 +293,7 @@ public InsertResponse insert(String tableName,
      */
     public InsertResponse insert(String tableName,
                                      InputStream data,
-                                     InsertSettings settings) throws IOException, ExecutionException, InterruptedException {
+                                     InsertSettings settings) throws IOException, ClientException {
         long s1 = System.currentTimeMillis();
         InsertResponse response;
         try (ClickHouseClient client = createClient()) {
@@ -306,7 +311,11 @@ public InsertResponse insert(String tableName,
                     stream.write(buffer, 0, bytesRead);
                 }
             }
-            response = new InsertResponse(client, future.get());
+            try {
+                response = new InsertResponse(client, future.get());
+            } catch (InterruptedException | ExecutionException e) {
+                throw new ClientException("Operation has likely timed out.", e);
+            }
         }
 
         long s2 = System.currentTimeMillis();

client-v2/src/main/java/com/clickhouse/client/api/exception/ClientException.java

@@ -0,0 +1,19 @@
+package com.clickhouse.client.api.exception;
+
+public class ClientException extends Throwable{
+    public ClientException() {
+        super();
+    }
+
+    public ClientException(Throwable cause) {
+        super(cause);
+    }
+
+    public ClientException(String message) {
+        super(message);
+    }
+
+    public ClientException(String message, Throwable cause) {
+        super(message, cause);
+    }
+}

client-v2/src/main/java/com/clickhouse/client/api/insert/InsertResponse.java

@@ -19,7 +19,10 @@ public ClickHouseResponseSummary getSummary() {
 
     @Override
     public void close() {
-        responseRef.close();
-        client.close();
+        try {
+            responseRef.close();
+        } finally {
+            client.close();
+        }
     }
 }

client-v2/src/test/java/com/clickhouse/client/insert/InsertTests.java

@@ -2,6 +2,7 @@
 
 import com.clickhouse.client.*;
 import com.clickhouse.client.api.Protocol;
+import com.clickhouse.client.api.exception.ClientException;
 import com.clickhouse.client.api.insert.InsertResponse;
 import com.clickhouse.client.api.insert.InsertSettings;
 import com.clickhouse.client.api.Client;
@@ -10,9 +11,7 @@
 import org.testng.annotations.Test;
 
 import java.io.IOException;
-import java.lang.reflect.InvocationTargetException;
 import java.util.*;
-import java.util.concurrent.ExecutionException;
 
 import static org.testng.Assert.*;
 
@@ -42,7 +41,7 @@ private void createTable(String tableQuery) throws ClickHouseException {
     }
 
     @Test(groups = { "unit" }, enabled = true)
-    public void insertSimplePOJOs() throws ClickHouseException, IOException, ExecutionException, InterruptedException, InvocationTargetException, IllegalAccessException {
+    public void insertSimplePOJOs() throws ClickHouseException, ClientException, IOException {
         String tableName = "simple_pojo_table";
         String createSQL = SamplePOJO.generateTableCreateSQL(tableName);
         System.out.println(createSQL);