Skip to content

Commit 264fa7a

Browse files
author
Paultagoras
committed
Adjusting tests
1 parent 14fe0d2 commit 264fa7a

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

client-v2/src/test/java/com/clickhouse/client/metrics/MetricsTest.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,32 +56,29 @@ public void testRegisterMetrics() throws Exception {
5656
Gauge available = meterRegistry.get("httpcomponents.httpclient.pool.total.connections").tags("state", "available").gauge();
5757
Gauge leased = meterRegistry.get("httpcomponents.httpclient.pool.total.connections").tags("state", "leased").gauge();
5858
Gauge times = meterRegistry.get("httpcomponents.httpclient.connect.time").gauge();
59-
Gauge ratio = meterRegistry.get("httpcomponents.httpclient.request.ratio").gauge();
6059

6160
System.out.println("totalMax:" + totalMax.value() +
6261
", available: " + available.value() +
6362
", leased: " + leased.value() +
64-
", times: " + times.value() +
65-
", ratio: " + ratio.value());
63+
", times: " + times.value());
6664
Assert.assertEquals((int)totalMax.value(), Integer.parseInt(ClientConfigProperties.HTTP_MAX_OPEN_CONNECTIONS.getDefaultValue()));
6765
Assert.assertEquals((int)available.value(), 1);
6866
Assert.assertEquals((int)leased.value(), 0);
69-
assertEquals((int)ratio.value(), 0);
7067

7168
try (QueryResponse response = client.query("SELECT 1").get()) {
7269
Assert.assertEquals((int)available.value(), 0);
7370
Assert.assertEquals((int)leased.value(), 1);
74-
assertEquals(ratio.value(), 0);
7571
}
7672

7773
Assert.assertEquals((int)available.value(), 1);
7874
Assert.assertEquals((int)leased.value(), 0);
7975
}
8076
// currently there are only 7 metrics that are monitored by micrometer (out of the box)
81-
assertEquals(meterRegistry.getMeters().size(), 7);
77+
assertEquals(meterRegistry.getMeters().size(), 6);
8278
}
8379

84-
@Test(groups = { "integration" }, enabled = true)
80+
//Disabled because we can't assume the time is greater than 0
81+
@Test(groups = { "integration" }, enabled = false)
8582
public void testConnectionTime() throws Exception {
8683
ClickHouseNode node = getServer(ClickHouseProtocol.HTTP);
8784
boolean isSecure = isCloud();

0 commit comments

Comments
 (0)