Skip to content

Commit 2723f41

Browse files
author
Paultagoras
committed
Remove comma
1 parent e489e7a commit 2723f41

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

jdbc-v2/src/main/java/com/clickhouse/jdbc/StatementImpl.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,11 @@ private boolean execute(String sql, QuerySettings settings) throws SQLException
309309
int roleIndex = JdbcUtils.indexOfIgnoresCase(tokens, "ROLE");
310310
if (roleIndex == 1) {
311311
for (int i = 2; i < tokens.size(); i++) {
312-
roles.add(tokens.get(i));
312+
String token = tokens.get(i);
313+
if (token.startsWith(",")) {
314+
token = token.substring(1);
315+
}
316+
roles.add(token);
313317
}
314318

315319
if (JdbcUtils.containsIgnoresCase(roles, "NONE")) {

jdbc-v2/src/test/java/com/clickhouse/jdbc/StatementTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -388,6 +388,15 @@ record = conn.client.queryAll("SELECT currentRoles()").get(0);
388388

389389
record = conn.client.queryAll("SELECT currentRoles()").get(0);
390390
assertEquals(record.getList(1).size(), 0);
391+
392+
try (Statement stmt = conn.createStatement()) {
393+
stmt.execute("SET ROLE \"role1\",\"role2\"");
394+
}
395+
396+
record = conn.client.queryAll("SELECT currentRoles()").get(0);
397+
assertEquals(record.getList(1).size(), 2);
398+
assertEquals(record.getList(1).get(0), "role1");
399+
assertEquals(record.getList(1).get(1), "role2");
391400
}
392401
}
393402

0 commit comments

Comments
 (0)