Skip to content

Commit 296d676

Browse files
committed
addressed some issues
1 parent 775d36d commit 296d676

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ jobs:
145145
matrix:
146146
# most recent LTS releases as well as latest stable builds
147147
# https://github.com/ClickHouse/ClickHouse/pulls?q=is%3Aopen+is%3Apr+label%3Arelease
148-
clickhouse: ["23.8", "24.3", "24.8", "latest"]
148+
clickhouse: ["24.3", "24.8", "latest"]
149149
project: ["clickhouse-http-client", "client-v2"]
150150
fail-fast: false
151151
timeout-minutes: 15
@@ -268,7 +268,7 @@ jobs:
268268
needs: compile
269269
strategy:
270270
matrix:
271-
clickhouse: ["23.8", "24.3", "24.8", "latest"]
271+
clickhouse: ["24.3", "24.8", "latest"]
272272
# here http, http_client and apache_http_client represent different value of http_connection_provider
273273
# protocol: ["http", "http_client", "apache_http_client"]
274274
protocol: ["apache_http_client"]
@@ -331,7 +331,7 @@ jobs:
331331
needs: compile
332332
strategy:
333333
matrix:
334-
clickhouse: ["23.8", "24.3", "24.8", "latest"]
334+
clickhouse: ["24.3", "24.8", "latest"]
335335
# grpc is not fully supported, and http_client and apache_http_client do not work in CI environment(due to limited threads?)
336336
protocol: ["http"]
337337
r2dbc: ["1.0.0.RELEASE", "0.9.1.RELEASE"]

client-v2/src/test/java/com/clickhouse/client/datatypes/DataTypeTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ public void testVariantWithSimpleDataTypes() throws Exception {
179179
continue dataTypesLoop;
180180

181181
}
182-
b.append(")) Engine = MergeTree ORDER BY () SETTINGS enable_variant_type=1");
182+
b.append(")) Engine = MergeTree ORDER BY () SETTINGS allow_experimental_dynamic_type=1");
183183

184184
client.execute(b.toString());
185185
client.register(DTOForVariantPrimitivesTests.class, client.getTableSchema(table));

0 commit comments

Comments
 (0)