Skip to content

Commit 29cf395

Browse files
committed
no retry by default because of risk
1 parent 1ec1c9a commit 29cf395

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

clickhouse-http-client/src/main/java/com/clickhouse/client/http/config/ClickHouseHttpOption.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public enum ClickHouseHttpOption implements ClickHouseOption {
8080
* <li>{@code 503 Service Unavailable}</li>
8181
* </ul>
8282
*/
83-
AHC_RETRY_ON_FAILURE("ahc_retry_on_failure", true, "Whether to retry on failure with AsyncHttpClient.")
83+
AHC_RETRY_ON_FAILURE("ahc_retry_on_failure", false, "Whether to retry on failure with AsyncHttpClient.")
8484
;
8585

8686
private final String key;

clickhouse-http-client/src/test/java/com/clickhouse/client/http/ApacheHttpConnectionImplTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,7 @@ public void testFailureWhileRequest() {
133133
.willReturn(WireMock.aResponse().withFault(Fault.EMPTY_RESPONSE)).build());
134134

135135
ClickHouseHttpClient httpClient = new ClickHouseHttpClient();
136-
Map<ClickHouseOption, Serializable> options = new HashMap<>();
137-
options.put(ClickHouseHttpOption.AHC_RETRY_ON_FAILURE, false);
138-
ClickHouseConfig config = new ClickHouseConfig(options);
136+
ClickHouseConfig config = new ClickHouseConfig();
139137
httpClient.init(config);
140138
ClickHouseRequest request = httpClient.read("http://localhost:9090/").query("SELECT 1");
141139

@@ -174,7 +172,9 @@ public void testRetryOnFailure() {
174172
.build());
175173

176174
ClickHouseHttpClient httpClient = new ClickHouseHttpClient();
177-
ClickHouseConfig config = new ClickHouseConfig();
175+
Map<ClickHouseOption, Serializable> options = new HashMap<>();
176+
options.put(ClickHouseHttpOption.AHC_RETRY_ON_FAILURE, true);
177+
ClickHouseConfig config = new ClickHouseConfig(options);
178178
httpClient.init(config);
179179
ClickHouseRequest request = httpClient.read("http://localhost:9090/").query("SELECT 1");
180180

0 commit comments

Comments
 (0)