Skip to content

Commit 33dc3df

Browse files
committed
fixed tests for older versions
1 parent 95b1750 commit 33dc3df

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

client-v2/src/test/java/com/clickhouse/client/metadata/MetadataTests.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ public void testCreateTableWithAllDataTypes() throws Exception {
120120
excludedTypes.add("Nullable"); // Nullable is a wrapper, not a base type
121121
excludedTypes.add("LowCardinality"); // LowCardinality is a wrapper, not a base type
122122
excludedTypes.add("Enum"); // Enum is a base type, use Enum8 or Enum16 instead
123+
excludedTypes.add("Object"); // Deprecated and not used for while
123124

124125
// Build column definitions
125126
StringBuilder createTableSql = new StringBuilder();
@@ -161,24 +162,29 @@ public void testCreateTableWithAllDataTypes() throws Exception {
161162
CommandSettings commandSettings = new CommandSettings();
162163
// Allow Geometry type which may have variant ambiguity
163164
commandSettings.serverSetting("allow_suspicious_variant_types", "1");
164-
// Allow QBit experimental type
165-
commandSettings.serverSetting("allow_experimental_qbit_type", "1");
166165
try {
167166
// Try to enable experimental types if version supports them
167+
if (isVersionMatch("[24.1,)")) {
168+
commandSettings.serverSetting("allow_experimental_variant_type", "1");
169+
}
168170
if (isVersionMatch("[24.8,)")) {
169-
commandSettings.serverSetting("allow_experimental_variant_type", "1")
170-
.serverSetting("allow_experimental_dynamic_type", "1")
171-
.serverSetting("allow_experimental_json_type", "1");
171+
commandSettings
172+
.serverSetting("allow_experimental_json_type", "1")
173+
.serverSetting("allow_experimental_dynamic_type", "1");
172174
}
173-
if (isVersionMatch("[25.8,)")) {
175+
if (isVersionMatch("[25.5,)")) {
174176
commandSettings.serverSetting("enable_time_time64_type", "1");
175177
}
178+
if (isVersionMatch("[25.10,)")) {
179+
commandSettings.serverSetting("allow_experimental_qbit_type", "1");
180+
}
176181
} catch (Exception e) {
177182
// If version check fails, continue without experimental settings
178183
}
179184

180185
try {
181186
client.execute("DROP TABLE IF EXISTS " + tableName).get().close();
187+
System.out.println(createTableSql);
182188
client.execute(createTableSql.toString(), commandSettings).get().close();
183189

184190
// Verify the schema

0 commit comments

Comments
 (0)