Skip to content

Commit 3453f77

Browse files
committed
rename GenericRecord#getAll to getValues
1 parent a171344 commit 3453f77

File tree

3 files changed

+24
-29
lines changed

3 files changed

+24
-29
lines changed

client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/BinaryReaderBackedRecord.java

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,18 @@
33
import com.clickhouse.client.api.data_formats.ClickHouseBinaryFormatReader;
44
import com.clickhouse.client.api.metadata.TableSchema;
55
import com.clickhouse.client.api.query.GenericRecord;
6-
import com.clickhouse.data.value.ClickHouseBitmap;
7-
import com.clickhouse.data.value.ClickHouseGeoMultiPolygonValue;
8-
import com.clickhouse.data.value.ClickHouseGeoPointValue;
9-
import com.clickhouse.data.value.ClickHouseGeoPolygonValue;
10-
import com.clickhouse.data.value.ClickHouseGeoRingValue;
6+
import com.clickhouse.data.ClickHouseColumn;
7+
import com.clickhouse.data.value.*;
118

129
import java.math.BigDecimal;
1310
import java.math.BigInteger;
1411
import java.net.Inet4Address;
1512
import java.net.Inet6Address;
16-
import java.time.Duration;
17-
import java.time.Instant;
18-
import java.time.LocalDate;
19-
import java.time.LocalDateTime;
20-
import java.time.ZonedDateTime;
13+
import java.time.*;
2114
import java.util.List;
15+
import java.util.Map;
2216
import java.util.UUID;
17+
import java.util.stream.Collectors;
2318

2419
public class BinaryReaderBackedRecord implements GenericRecord {
2520

@@ -383,4 +378,11 @@ public ClickHouseBitmap getClickHouseBitmap(int index) {
383378
public TableSchema getSchema() {
384379
return reader.getSchema();
385380
}
381+
382+
@Override
383+
public Map<String, Object> getValues() {
384+
return this.getSchema().getColumns().stream().collect(Collectors.toMap(
385+
ClickHouseColumn::getColumnName,
386+
column -> this.getObject(column.getColumnName())));
387+
}
386388
}

client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/MapBackedRecord.java

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,24 +5,18 @@
55
import com.clickhouse.client.api.query.GenericRecord;
66
import com.clickhouse.client.api.query.NullValueException;
77
import com.clickhouse.data.ClickHouseColumn;
8-
import com.clickhouse.data.value.ClickHouseBitmap;
9-
import com.clickhouse.data.value.ClickHouseGeoMultiPolygonValue;
10-
import com.clickhouse.data.value.ClickHouseGeoPointValue;
11-
import com.clickhouse.data.value.ClickHouseGeoPolygonValue;
12-
import com.clickhouse.data.value.ClickHouseGeoRingValue;
8+
import com.clickhouse.data.value.*;
139

1410
import java.math.BigDecimal;
1511
import java.math.BigInteger;
1612
import java.net.Inet4Address;
1713
import java.net.Inet6Address;
18-
import java.time.Duration;
19-
import java.time.Instant;
20-
import java.time.LocalDate;
21-
import java.time.LocalDateTime;
22-
import java.time.ZoneOffset;
23-
import java.time.ZonedDateTime;
14+
import java.time.*;
2415
import java.time.temporal.ChronoUnit;
25-
import java.util.*;
16+
import java.util.HashMap;
17+
import java.util.List;
18+
import java.util.Map;
19+
import java.util.UUID;
2620
import java.util.function.Function;
2721

2822
public class MapBackedRecord implements GenericRecord {
@@ -523,4 +517,9 @@ public Object getObject(String colName) {
523517
public Object getObject(int index) {
524518
return readValue(index);
525519
}
520+
521+
@Override
522+
public Map<String, Object> getValues() {
523+
return this.record;
524+
}
526525
}

client-v2/src/main/java/com/clickhouse/client/api/query/GenericRecord.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.clickhouse.client.api.query;
22

33
import com.clickhouse.client.api.metadata.TableSchema;
4-
import com.clickhouse.data.ClickHouseColumn;
54
import com.clickhouse.data.value.*;
65

76
import java.math.BigDecimal;
@@ -12,7 +11,6 @@
1211
import java.util.List;
1312
import java.util.Map;
1413
import java.util.UUID;
15-
import java.util.stream.Collectors;
1614

1715
public interface GenericRecord {
1816

@@ -504,9 +502,5 @@ public interface GenericRecord {
504502
*
505503
* @return a Map of column names and values.
506504
*/
507-
default Map<String, Object> getAll() {
508-
return this.getSchema().getColumns().stream().collect(Collectors.toMap(
509-
ClickHouseColumn::getColumnName,
510-
column -> this.getObject(column.getColumnName())));
511-
}
505+
Map<String, Object> getValues();
512506
}

0 commit comments

Comments
 (0)