added JDBC tests

Author: chernser

client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java

@@ -477,7 +477,7 @@ public ZonedDateTime getZonedDateTime(String colName) {
             case Date32:
                 return readValue(colName);
             default:
-                throw new ClientException("Column of type " + column.getDataType() + " cannot be converted to Instant");
+                throw new ClientException("Column of type " + column.getDataType() + " cannot be converted to ZonedDateTime");
         }
     }
 

client-v2/src/test/java/com/clickhouse/client/datatypes/DataTypeTests.java

@@ -687,7 +687,7 @@ public void testAllDataTypesKnown() {
     }
 
     @Test(groups = {"integration"})
-    public void testTimeType() throws Exception {
+    public void testTime64() throws Exception {
         if (isVersionMatch("(,25.4]")) {
             return;
         }
@@ -696,7 +696,7 @@ public void testTimeType() throws Exception {
         client.execute("DROP TABLE IF EXISTS " + table).get();
         client.execute(tableDefinition(table, "o_num UInt32", "time Time"), (CommandSettings) new CommandSettings().serverSetting("enable_time_time64_type", "1")).get();
 
-        String insertSQL = "INSERT INTO " + table + " VALUES (1, '999:00:00'), (2, '999:59:00'), (3, '000:00:00')";
+        String insertSQL = "INSERT INTO " + table + " VALUES (1, '999:00:00'), (2, '999:59:00'), (3, '000:00:00'), (4, '-999:59:59')";
         try (QueryResponse response = client.query(insertSQL).get()) {}
 
 
@@ -716,6 +716,11 @@ record = records.get(2);
         Assert.assertEquals(record.getInteger("o_num"), 3);
         Assert.assertEquals(record.getInteger("time"), 0);
         Assert.assertEquals(record.getInstant("time"), Instant.ofEpochSecond(0));
+
+        record = records.get(3);
+        Assert.assertEquals(record.getInteger("o_num"), 4);
+        Assert.assertEquals(record.getInteger("time"), - (TimeUnit.HOURS.toSeconds(999) + TimeUnit.MINUTES.toSeconds(59)));
+        Assert.assertEquals(record.getInstant("time"), Instant.ofEpochSecond(TimeUnit.HOURS.toSeconds(999) + TimeUnit.MINUTES.toSeconds(59)));
     }
 
 

jdbc-v2/src/test/java/com/clickhouse/jdbc/DataTypeTests.java

@@ -41,10 +41,12 @@
 import java.util.Random;
 import java.util.TimeZone;
 import java.util.UUID;
+import java.util.concurrent.TimeUnit;
 
 import static org.testng.Assert.assertEquals;
 import static org.testng.Assert.assertFalse;
 import static org.testng.Assert.assertNull;
+import static org.testng.Assert.assertThrows;
 import static org.testng.Assert.assertTrue;
 
 @Test(groups = { "integration" })
@@ -550,6 +552,42 @@ public void testDateTypes() throws SQLException {
         }
     }
 
+
+    @Test(groups = { "integration" })
+    public void testTimeTypes() throws SQLException {
+        Properties createProperties = new Properties();
+        createProperties.put(ClientConfigProperties.serverSetting("enable_time_time64_type"), "1");
+        runQuery("CREATE TABLE test_time64 (order Int8, "
+                + "time Time('UTC'), time64 Time64(9) "
+                + ") ENGINE = MergeTree ORDER BY ()",
+                createProperties);
+
+        runQuery("INSERT INTO test_time64 (order, time, time64) VALUES " +
+                "   (1, '-999:59:59', '-999:59:59.999999999'), " +
+                "   (2, '999:59:59', '999:59:59.999999999')");
+
+        // Check the results
+        try (Statement stmt = getJdbcConnection().createStatement()) {
+            try (ResultSet rs = stmt.executeQuery("SELECT * FROM test_time64")) {
+                assertTrue(rs.next());
+                assertEquals(rs.getInt("order"), 1);
+//                assertEquals(rs.getInt("time"), -(TimeUnit.HOURS.toSeconds(999) + TimeUnit.MINUTES.toSeconds(59) + 59));
+//                assertEquals(rs.getInt("time64"), -(TimeUnit.HOURS.toSeconds(999) + TimeUnit.MINUTES.toSeconds(59) + 59));
+
+                assertTrue(rs.next());
+                assertEquals(rs.getInt("order"), 2);
+                assertEquals(rs.getInt("time"), (TimeUnit.HOURS.toSeconds(999) + TimeUnit.MINUTES.toSeconds(59) + 59));
+                assertEquals(rs.getLong("time64"), (TimeUnit.HOURS.toNanos(999) + TimeUnit.MINUTES.toNanos(59) + TimeUnit.SECONDS.toNanos(59)) + 999999999);
+
+                assertThrows(SQLException.class, () -> rs.getTime("time"));
+                assertThrows(SQLException.class, () -> rs.getDate("time"));
+                assertThrows(SQLException.class, () -> rs.getTimestamp("time"));
+
+                assertFalse(rs.next());
+            }
+        }
+    }
+
     @Test(groups = { "integration" })
     public void testStringTypes() throws SQLException {
         runQuery("CREATE TABLE test_strings (order Int8, "