Skip to content

Commit 4661eb9

Browse files
author
Paultagoras
committed
Tweaking default detection
1 parent e70a069 commit 4661eb9

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

clickhouse-data/src/main/java/com/clickhouse/data/ClickHouseColumn.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,7 @@ private ClickHouseColumn(ClickHouseDataType dataType, String columnName, String
589589
this.originalTypeName = originalTypeName == null ? dataType.name() : originalTypeName;
590590
this.nullable = nullable;
591591
this.lowCardinality = lowCardinality;
592-
this.hasDefault = originalTypeName != null && originalTypeName.toUpperCase().contains("DEFAULT");
592+
this.hasDefault = false;
593593

594594
if (parameters == null || parameters.isEmpty()) {
595595
this.parameters = Collections.emptyList();
@@ -734,6 +734,10 @@ public boolean hasDefault() {
734734
return hasDefault;
735735
}
736736

737+
public void setHasDefault(boolean hasDefault) {
738+
this.hasDefault = hasDefault;
739+
}
740+
737741
public boolean isLowCardinality() {
738742
return !lowCardinalityDisabled && lowCardinality;
739743
}

client-v2/src/main/java/com/clickhouse/client/api/Client.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
package com.clickhouse.client.api;
22

33
import com.clickhouse.client.ClickHouseClient;
4-
import com.clickhouse.client.ClickHouseClientBuilder;
5-
import com.clickhouse.client.ClickHouseConfig;
64
import com.clickhouse.client.ClickHouseNode;
7-
import com.clickhouse.client.ClickHouseNodeSelector;
8-
import com.clickhouse.client.ClickHouseProtocol;
95
import com.clickhouse.client.ClickHouseRequest;
106
import com.clickhouse.client.ClickHouseResponse;
117
import com.clickhouse.client.api.data_formats.ClickHouseBinaryFormatReader;
@@ -31,7 +27,6 @@
3127
import com.clickhouse.client.api.query.QuerySettings;
3228
import com.clickhouse.client.api.query.Records;
3329
import com.clickhouse.client.config.ClickHouseClientOption;
34-
import com.clickhouse.config.ClickHouseOption;
3530
import com.clickhouse.data.ClickHouseColumn;
3631
import com.clickhouse.data.ClickHouseDataStreamFactory;
3732
import com.clickhouse.data.ClickHouseFormat;
@@ -44,7 +39,6 @@
4439
import java.io.ByteArrayOutputStream;
4540
import java.io.IOException;
4641
import java.io.InputStream;
47-
import java.io.Serializable;
4842
import java.lang.reflect.InvocationTargetException;
4943
import java.lang.reflect.Method;
5044
import java.net.URL;

client-v2/src/main/java/com/clickhouse/client/api/metadata/TableSchema.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,13 @@ public void addColumn(String name, String type) {
6161
addColumn(name, type, "");
6262
}
6363
public void addColumn(String name, String type, String defaultType) {
64-
columns.add(ClickHouseColumn.of(name, type));
64+
ClickHouseColumn column = ClickHouseColumn.of(name, type);
6565
if (defaultType.toUpperCase().contains("DEFAULT")) {
6666
hasDefaults = true;
67+
column.setHasDefault(true);
6768
}
69+
columns.add(column);
70+
6871
Map<String, Object> columnMetadata = metadata.computeIfAbsent(name, k -> new HashMap<>());
6972
columnMetadata.put("type", type);
7073
colIndex.put(name, columns.size() - 1);

0 commit comments

Comments
 (0)