moved ValueConverters instance to static init of ArrayResultSet. Added wrapping try-catch for exception while convertions

Author: chernser

jdbc-v2/src/main/java/com/clickhouse/jdbc/types/ArrayResultSet.java

@@ -47,6 +47,8 @@ public class ArrayResultSet implements ResultSet {
 
     private static final ClickHouseColumn INDEX_COLUMN = ClickHouseColumn.of("INDEX", ClickHouseDataType.UInt32, false, 0, 0);
     private static final String VALUE_COLUMN = "VALUE";
+    private static final ValueConverters defaultValueConverters = new ValueConverters();
+
     private int fetchDirection = ResultSet.FETCH_FORWARD;
     private int fetchSize = 0;
     private boolean wasNull = false;
@@ -71,14 +73,13 @@ public ArrayResultSet(Object array, ClickHouseColumn column) {
                 , "", "", "", JdbcUtils.DATA_TYPE_CLASS_MAP);
         this.componentDataType = valueColumn.getDataType();
         this.defaultClass = JdbcUtils.DATA_TYPE_CLASS_MAP.get(componentDataType);
-        ValueConverters converters = new ValueConverters();
-        indexConverterMap = converters.getConvertersForType(Integer.class);
+        indexConverterMap = defaultValueConverters.getConvertersForType(Integer.class);
         if (this.length > 0) {
             Class<?> itemClass = array.getClass().getComponentType();
             if (itemClass == null) {
                 itemClass = java.lang.reflect.Array.get(array, 0).getClass();
             }
-            converterMap = converters.getConvertersForType(itemClass);
+            converterMap = defaultValueConverters.getConvertersForType(itemClass);
         } else {
             // empty array - no values to convert
             converterMap = null;
@@ -127,7 +128,12 @@ private Object getValueAsObject(int columnIndex, Class<?> type, Object defaultVa
             // if there is something to convert. type == Object.class means no conversion
             Function<Object, Object> converter = valueConverterMap.get(type);
             if (converter != null) {
-                value = converter.apply(value);
+                try {
+                    value = converter.apply(value);
+                } catch (Exception e) {
+                    throw new SQLException("Failed to convert value of " + value.getClass() + " to " + type,
+                            ExceptionUtils.SQL_STATE_DATA_EXCEPTION, e);
+                }
             } else {
                 throw new SQLException("Value of " + value.getClass() + " cannot be converted to " + type);
             }

jdbc-v2/src/test/java/com/clickhouse/jdbc/types/ArrayResultSetTest.java

@@ -505,4 +505,19 @@ void testStringToURL() throws Exception {
         assertEquals(rs.getString(stringColumn), rs.getObject(stringColumn, String.class));
         assertEquals(rs.getURL(stringColumn), rs.getObject(stringColumn, URL.class));
     }
+
+    @Test
+    void testInvalidStringConverts() throws Exception {
+        String[] array = {"abc"};
+        ArrayResultSet rs = new ArrayResultSet(array, ClickHouseColumn.parse("v Array(String)").get(0));
+
+        final String stringColumn = rs.getMetaData().getColumnName(2);
+        rs.next();
+        Assert.assertThrows(SQLException.class, () -> rs.getByte(stringColumn));
+        Assert.assertThrows(SQLException.class, () -> rs.getShort(stringColumn));
+        Assert.assertThrows(SQLException.class, () -> rs.getInt(stringColumn));
+        Assert.assertThrows(SQLException.class, () -> rs.getLong(stringColumn));
+        Assert.assertThrows(SQLException.class, () -> rs.getFloat(stringColumn));
+        Assert.assertThrows(SQLException.class, () -> rs.getDouble(stringColumn));
+    }
 }