Fixing older (unimplemented) tests

Author: Paultagoras

jdbc-v2/src/main/java/com/clickhouse/jdbc/ConnectionImpl.java

@@ -393,7 +393,8 @@ public void setClientInfo(Properties properties) throws SQLClientInfoException {
     @Override
     public String getClientInfo(String name) throws SQLException {
         checkOpen();
-        return String.valueOf(this.defaultQuerySettings.getAllSettings().get(name));
+        Object value = this.defaultQuerySettings.getAllSettings().get(name);
+        return value == null ? null : String.valueOf(value);
     }
 
     @Override

jdbc-v2/src/test/java/com/clickhouse/jdbc/ConnectionTest.java

@@ -90,8 +90,8 @@ public void getMetaDataTest() throws SQLException {
     @Test
     public void setReadOnlyTest() throws SQLException {
         Connection localConnection = this.getJdbcConnection();
-        localConnection.setReadOnly(true);
-        Assert.assertThrows(SQLFeatureNotSupportedException.class, () -> localConnection.setReadOnly(false));
+        localConnection.setReadOnly(false);
+        Assert.assertThrows(SQLFeatureNotSupportedException.class, () -> localConnection.setReadOnly(true));
     }
 
     @Test
@@ -177,25 +177,25 @@ public void releaseSavepointTest() throws SQLException {
     @Test
     public void createClobTest() throws SQLException {
         Connection localConnection = this.getJdbcConnection();
-        Assert.assertThrows(SQLFeatureNotSupportedException.class, () -> localConnection.createClob());
+        Assert.assertNotNull(localConnection.createClob());
     }
 
     @Test
     public void createBlobTest() throws SQLException {
         Connection localConnection = this.getJdbcConnection();
-        Assert.assertThrows(SQLFeatureNotSupportedException.class, () -> localConnection.createBlob());
+        Assert.assertNotNull(localConnection.createBlob());
     }
 
     @Test
     public void createNClobTest() throws SQLException {
         Connection localConnection = this.getJdbcConnection();
-        Assert.assertThrows(SQLFeatureNotSupportedException.class, () -> localConnection.createNClob());
+        Assert.assertNotNull(localConnection.createNClob());
     }
 
     @Test
     public void createSQLXMLTest() throws SQLException {
         Connection localConnection = this.getJdbcConnection();
-        Assert.assertThrows(SQLFeatureNotSupportedException.class, () -> localConnection.createSQLXML());
+        Assert.assertThrows(SQLFeatureNotSupportedException.class, localConnection::createSQLXML);
     }
 
     @Test
@@ -206,23 +206,20 @@ public void isValidTest() throws SQLException {
     }
 
     @Test
-    public void setClientInfoTest() throws SQLException {
-        Connection localConnection = this.getJdbcConnection();
-        Assert.assertThrows(SQLClientInfoException.class, () -> localConnection.setClientInfo("key", "value"));
-        Assert.assertThrows(SQLClientInfoException.class, () -> localConnection.setClientInfo(new Properties()));
-    }
-
-    @Test
-    public void getClientInfoTest() throws SQLException {
+    public void setAndGetClientInfoTest() throws SQLException {
         Connection localConnection = this.getJdbcConnection();
         Assert.assertNull(localConnection.getClientInfo("key"));
-        Assert.assertNotNull(localConnection.getClientInfo());
+        localConnection.setClientInfo("key", "value");
+        Assert.assertNotNull(localConnection.getClientInfo("key"));
     }
 
+
     @Test
     public void createArrayOfTest() throws SQLException {
         Connection localConnection = this.getJdbcConnection();
-        Assert.assertNull(localConnection.createArrayOf("type-name", new Object[] { 1, 2, 3 }));
+        Array array = localConnection.createArrayOf("type-name", new Object[] { 1, 2, 3 });
+        Assert.assertNotNull(array);
+        Assert.assertEquals(array.getArray(), new Object[] { 1, 2, 3 });
     }
 
     @Test

jdbc-v2/src/test/java/com/clickhouse/jdbc/DataSourceTest.java

@@ -5,6 +5,7 @@
 import java.sql.SQLFeatureNotSupportedException;
 import java.util.Properties;
 
+import static org.testng.Assert.assertNull;
 import static org.testng.Assert.assertThrows;
 import static org.testng.Assert.assertNotNull;
 
@@ -46,13 +47,13 @@ public void testGetConnectionWithUserAndPassword() throws SQLException {
     }
 
     @Test
-    public void testGetLogWriter() {
-        assertThrows(SQLFeatureNotSupportedException.class, () -> dataSource.getLogWriter());
+    public void testGetLogWriter() throws SQLException {
+        assertNull(dataSource.getLogWriter());
     }
 
     @Test
-    public void testSetLogWriter() {
-        assertThrows(SQLFeatureNotSupportedException.class, () -> dataSource.setLogWriter(null));
+    public void testSetLogWriter() throws SQLException {
+        dataSource.setLogWriter(null);
     }
 
     @Test