Skip to content

Commit 51ab08b

Browse files
committed
Replace with beforemethod annotation
1 parent 34e5f39 commit 51ab08b

16 files changed

+5
-69
lines changed

clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/AccessManagementTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@
1717
import java.util.Properties;
1818

1919
public class AccessManagementTest extends JdbcIntegrationTest {
20-
@BeforeClass
21-
public void setUp() {
22-
System.setProperty("clickhouse.jdbc.v1","true");
23-
}
24-
2520
@Test(groups = "integration", dataProvider = "setRolesArgsForTestSetRole")
2621
public void testSetRoleDifferentConnections(String[] roles, String setRoleExpr, String[] activeRoles,
2722
String connectionProvider) throws SQLException {

clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/ClickHouseConnectionTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@
2222
import org.testng.annotations.Test;
2323

2424
public class ClickHouseConnectionTest extends JdbcIntegrationTest {
25-
@BeforeClass
26-
public void setUp() {
27-
System.setProperty("clickhouse.jdbc.v1","true");
28-
}
2925
@Override
3026
public ClickHouseConnection newConnection(Properties properties) throws SQLException {
3127
return (ClickHouseConnection) newDataSource(properties).getConnection();

clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/ClickHouseDataSourceTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@
2020
import com.clickhouse.client.config.ClickHouseDefaults;
2121

2222
public class ClickHouseDataSourceTest extends JdbcIntegrationTest {
23-
@BeforeClass
24-
public void setUp() {
25-
System.setProperty("clickhouse.jdbc.v1","true");
26-
}
2723
@Test(groups = "integration")
2824
public void testHighAvailabilityConfig() throws SQLException {
2925
if (isCloud() || ClickHouseDriver.isV2()) return; //TODO: testHighAvailabilityConfig - Revisit, see: https://github.com/ClickHouse/clickhouse-java/issues/1747

clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/ClickHouseDatabaseMetaDataTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,13 @@
1717
import com.clickhouse.logging.LoggerFactory;
1818
import org.testng.Assert;
1919
import org.testng.annotations.BeforeClass;
20+
import org.testng.annotations.BeforeMethod;
2021
import org.testng.annotations.DataProvider;
2122
import org.testng.annotations.Test;
2223

2324
public class ClickHouseDatabaseMetaDataTest extends JdbcIntegrationTest {
24-
@BeforeClass
25-
public void setUp() {
25+
@BeforeMethod(groups = "integration")
26+
public void setV1() {
2627
System.setProperty("clickhouse.jdbc.v1","true");
2728
}
2829

clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/ClickHouseDriverTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ public void testConnect() throws SQLException {
3131
}
3232
@Test(groups = "integration")
3333
public void testV2Driver() {
34+
System.setProperty("clickhouse.jdbc.v1","false");
3435
ClickHouseDriver driver = new ClickHouseDriver();
3536
Boolean V1 = false;
3637
Boolean V2 = true;
@@ -39,6 +40,6 @@ public void testV2Driver() {
3940
Assert.assertEquals(driver.isV2("jdbc:clickhouse://localhost:8123?clickhouse.jdbc.v1=false"), V2);
4041
Assert.assertEquals(driver.isV2("jdbc:clickhouse://localhost:8123?clickhouse.jdbc.v2=true"), V2);
4142
Assert.assertEquals(driver.isV2("jdbc:clickhouse://localhost:8123?clickhouse.jdbc.v2=false"), V1);
42-
43+
System.setProperty("clickhouse.jdbc.v1","true");
4344
}
4445
}

clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/ClickHousePreparedStatementTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,6 @@
6666
import org.testng.annotations.Test;
6767

6868
public class ClickHousePreparedStatementTest extends JdbcIntegrationTest {
69-
@BeforeClass
70-
public void setUp() {
71-
System.setProperty("clickhouse.jdbc.v1","true");
72-
}
7369
@DataProvider(name = "columnsWithDefaultValue")
7470
private Object[][] getColumnsWithDefaultValue() {
7571
return new Object[][] {

clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/ClickHouseResultSetTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,6 @@
3939
import org.testng.annotations.Test;
4040

4141
public class ClickHouseResultSetTest extends JdbcIntegrationTest {
42-
@BeforeClass
43-
public void setUp() {
44-
System.setProperty("clickhouse.jdbc.v1","true");
45-
}
4642
@DataProvider(name = "nullableTypes")
4743
private Object[][] getNullableTypes() {
4844
return new Object[][] {

clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/ClickHouseStatementTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,6 @@
6060
import java.util.concurrent.atomic.AtomicReference;
6161

6262
public class ClickHouseStatementTest extends JdbcIntegrationTest {
63-
@BeforeClass
64-
public void setUp() {
65-
System.setProperty("clickhouse.jdbc.v1","true");
66-
}
67-
6863
@DataProvider(name = "timeZoneTestOptions")
6964
private Object[][] getTimeZoneTestOptions() {
7065
return new Object[][] {

clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/CombinedResultSetTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@
1616
import com.clickhouse.data.ClickHouseColumn;
1717

1818
public class CombinedResultSetTest {
19-
@BeforeClass
20-
public void setUp() {
21-
System.setProperty("clickhouse.jdbc.v1","true");
22-
}
23-
2419
@DataProvider(name = "multipleResultSetsProvider")
2520
private Object[][] getMultipleResultSets() {
2621
ClickHouseConfig config = new ClickHouseConfig();

clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/GenericJDBCTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,6 @@
1010
import static org.testng.Assert.assertThrows;
1111

1212
public class GenericJDBCTest extends JdbcIntegrationTest {
13-
@BeforeClass
14-
public void setUp() {
15-
System.setProperty("clickhouse.jdbc.v1","true");
16-
}
17-
1813
public Connection getConnection(Properties properties) throws SQLException {
1914
if (properties == null) {
2015
properties = new Properties();

0 commit comments

Comments
 (0)