Skip to content

Commit 586a4a7

Browse files
committed
corrected some comments
1 parent d38b0f9 commit 586a4a7

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

performance/src/test/com/clickhouse/benchmark/BenchmarkRunner.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public static void main(String[] args) throws Exception {
3939
.threads(1)
4040
.addProfiler(GCProfiler.class)
4141
.addProfiler(MemPoolProfiler.class)
42-
.warmupIterations(0)
42+
.warmupIterations(3)
4343
.warmupTime(TimeValue.seconds(10))
4444
.measurementIterations(10)
4545
.jvmArgs("-Xms8g", "-Xmx8g")

performance/src/test/com/clickhouse/benchmark/clients/BenchmarkBase.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ public class BenchmarkBase {
5252
protected Client clientV2;
5353
@Setup(Level.Iteration)
5454
public void setUpIteration() {
55-
// ClickHouseServerForTest.beforeSuite();
5655
clientV1 = getClientV1();
5756
clientV2 = getClientV2();
5857

@@ -74,8 +73,7 @@ public void tearDownIteration() {
7473
public static class DataState {
7574
@Param({"file://dataset_500k.csv"})
7675
String datasetSourceName;
77-
// @Param({"300000", "220000", "100000", "10000"})
78-
@Param({"100000", "10000"})
76+
@Param({"300000", "220000", "100000", "10000"})
7977
int limit;
8078
@Param({"data_filled"})
8179
String tableNameFilled;

performance/src/test/com/clickhouse/benchmark/clients/Components.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,11 @@ public class Components extends BenchmarkBase {
1717
@Benchmark
1818
public void CompressingOutputStreamV1(DataState dataState) {
1919
DataSet dataSet = dataState.dataSet;
20-
2120
try (ByteArrayOutputStream baos = new ByteArrayOutputStream(); ClickHouseOutputStream out =
22-
new Lz4OutputStream(baos, 4 * 8196, null)) {
21+
new Lz4OutputStream(baos, 8196, null)) {
2322
for (byte[] bytes : dataSet.getBytesList(dataSet.getFormat())) {
2423
out.write(bytes);
2524
}
26-
int size = baos.size();
27-
LOGGER.info("Compressed size: " + size);
2825
} catch (Exception e) {
2926
LOGGER.error("Error: ", e);
3027
}
@@ -35,10 +32,9 @@ public void CompressingOutputStreamV1(DataState dataState) {
3532
@Benchmark
3633
public void CompressingOutputStreamV2(DataState dataState) {
3734
DataSet dataSet = dataState.dataSet;
38-
3935
try (ByteArrayOutputStream baos = new ByteArrayOutputStream();
4036
ClickHouseLZ4OutputStream out = new ClickHouseLZ4OutputStream(baos,
41-
factory.fastCompressor(), 4 * 8196)) {
37+
factory.fastCompressor(), 8196)) {
4238
for (byte[] bytes : dataSet.getBytesList(dataSet.getFormat())) {
4339
out.write(bytes);
4440
}

0 commit comments

Comments
 (0)