Skip to content

Commit 6d0f5bc

Browse files
committed
added tests for metadata
1 parent 0604ac5 commit 6d0f5bc

File tree

2 files changed

+23
-0
lines changed

2 files changed

+23
-0
lines changed

jdbc-v2/src/main/java/com/clickhouse/jdbc/ResultSetImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -453,6 +453,7 @@ public void clearWarnings() throws SQLException {
453453
@Override
454454
public String getCursorName() throws SQLException {
455455
checkClosed();
456+
featureManager.unsupportedFeatureThrow("getCursorName");
456457
return "";
457458
}
458459

jdbc-v2/src/test/java/com/clickhouse/jdbc/ResultSetImplTest.java

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,10 @@
1616
import java.sql.NClob;
1717
import java.sql.Ref;
1818
import java.sql.ResultSet;
19+
import java.sql.ResultSetMetaData;
1920
import java.sql.SQLException;
2021
import java.sql.SQLFeatureNotSupportedException;
22+
import java.sql.SQLType;
2123
import java.sql.Statement;
2224
import java.sql.Time;
2325
import java.sql.Timestamp;
@@ -192,6 +194,7 @@ public void testUnsupportedOperations() throws Throwable {
192194
() -> rs.rowDeleted(),
193195
() -> rs.rowInserted(),
194196
() -> rs.rowUpdated(),
197+
() -> rs.getCursorName(),
195198
};
196199

197200
for (Assert.ThrowingRunnable op : rsUnsupportedMethods) {
@@ -266,6 +269,7 @@ public void testFetchDirectionsAndSize() throws SQLException {
266269
public void testConstants() throws SQLException {
267270
try (Connection conn = getJdbcConnection(); Statement stmt = conn.createStatement()) {
268271
try (ResultSet rs = stmt.executeQuery("select number from system.numbers LIMIT 2")) {
272+
Assert.assertSame(rs.getStatement(), stmt);
269273
Assert.assertEquals(rs.getType(), ResultSet.TYPE_FORWARD_ONLY);
270274
Assert.assertEquals(rs.getConcurrency(), ResultSet.CONCUR_READ_ONLY);
271275
Assert.assertEquals(rs.getHoldability(), ResultSet.HOLD_CURSORS_OVER_COMMIT);
@@ -324,4 +328,22 @@ public void testWasNull() throws SQLException {
324328
}
325329
}
326330
}
331+
332+
@Test(groups = {"integration"})
333+
public void testGetMetadata() throws SQLException {
334+
try (Connection conn = getJdbcConnection(); Statement stmt = conn.createStatement()) {
335+
try (ResultSet rs = stmt.executeQuery("select '1'::Int32 as v1, 'test' as v2 ")) {
336+
337+
int v1ColumnIndex = rs.findColumn("v1");
338+
int v2ColumnIndex = rs.findColumn("v2");
339+
340+
ResultSetMetaData metaData = rs.getMetaData();
341+
Assert.assertEquals(metaData.getColumnCount(), 2);
342+
Assert.assertEquals(metaData.getColumnType(1), Types.INTEGER);
343+
Assert.assertEquals(metaData.getColumnType(2), Types.VARCHAR);
344+
Assert.assertEquals(metaData.getColumnTypeName(1), "Int32");
345+
Assert.assertEquals(metaData.getColumnTypeName(2), "String");
346+
}
347+
}
348+
}
327349
}

0 commit comments

Comments
 (0)