Merge pull request #2305 from CCweixiao/dev-2299

[jdbc-v2] Fixes in the PreparedStatementImpl class, the initial length of the parameters is incorrectly changed in the clearParameters method

Author: chernser

jdbc-v2/src/main/java/com/clickhouse/jdbc/PreparedStatementImpl.java

@@ -90,7 +90,7 @@ public PreparedStatementImpl(ConnectionImpl connection, String sql) throws SQLEx
         this.parameterMetaData = new ParameterMetaDataImpl(this.parameters.length);
     }
 
-    private String compileSql(String [] segments) {
+    private String compileSql(String []segments) {
         StringBuilder sb = new StringBuilder();
         for (int i = 0; i < segments.length; i++) {
             sb.append(segments[i]);
@@ -217,7 +217,7 @@ public void setBinaryStream(int parameterIndex, InputStream x, int length) throw
     public void clearParameters() throws SQLException {
         checkClosed();
         if (originalSql.contains("?")) {
-            this.parameters = new Object[sqlSegments.length];
+            this.parameters = new Object[sqlSegments.length - 1];
         } else {
             this.parameters = new Object[0];
         }

jdbc-v2/src/test/java/com/clickhouse/jdbc/PreparedStatementTest.java

@@ -10,7 +10,6 @@
 import java.sql.Connection;
 import java.sql.PreparedStatement;
 import java.sql.ResultSet;
-import java.sql.ResultSetMetaData;
 import java.sql.Statement;
 import java.sql.Types;
 import java.util.Arrays;
@@ -553,4 +552,31 @@ void testStatementSplit() throws Exception {
 
         }
     }
+
+    @Test(groups = {"integration"})
+    void testClearParameters() throws Exception {
+        String sql = "insert into `test_issue_2299` (`id`, `name`, `age`) values (?, ?, ?)";
+        try (Connection conn = getJdbcConnection();
+             PreparedStatementImpl ps = (PreparedStatementImpl) conn.prepareStatement(sql)) {
+
+            try (Statement stmt = conn.createStatement()) {
+                stmt.execute("CREATE TABLE IF NOT EXISTS `test_issue_2299` (`id` Nullable(String), `name` Nullable(String), `age` Int32) ENGINE Memory;");
+            }
+
+            Assert.assertEquals(ps.parameters.length, 3);
+
+            ps.setString(1, "testId");
+            ps.setString(2, "testName");
+            ps.setInt(3, 18);
+            ps.execute();
+
+            ps.clearParameters();
+            Assert.assertEquals(ps.parameters.length, 3);
+
+            ps.setString(1, "testId2");
+            ps.setString(2, "testName2");
+            ps.setInt(3, 19);
+            ps.execute();
+        }
+    }
 }