Skip to content

Commit 7abb0ac

Browse files
authored
Merge pull request #1632 from ClickHouse/fix_long_running_test
#1631 Implemented test in more stable way
2 parents 71a9b6e + f189318 commit 7abb0ac

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

clickhouse-client/src/test/java/com/clickhouse/client/ClientIntegrationTest.java

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.clickhouse.client.ClickHouseClientBuilder.Agent;
44
import com.clickhouse.client.ClickHouseTransaction.XID;
55
import com.clickhouse.client.config.ClickHouseClientOption;
6+
import com.clickhouse.client.config.ClickHouseDefaults;
67
import com.clickhouse.config.ClickHouseBufferingMode;
78
import com.clickhouse.config.ClickHouseOption;
89
import com.clickhouse.config.ClickHouseRenameMethod;
@@ -71,6 +72,7 @@
7172
import java.nio.file.Paths;
7273
import java.util.ArrayList;
7374
import java.util.Collections;
75+
import java.util.HashMap;
7476
import java.util.List;
7577
import java.util.Map;
7678
import java.util.Map.Entry;
@@ -2023,26 +2025,21 @@ public void testErrorDuringInsert() throws ClickHouseException {
20232025

20242026
@Test(groups = "integration")
20252027
public void testErrorDuringQuery() throws ClickHouseException {
2028+
// Note: server may return no records but only error
20262029
ClickHouseNode server = getServer();
2027-
String query = "select number, throwIf(number>=10000000) from numbers(500000000)";
2028-
long count = 0L;
2030+
String query = "select number, throwIf(number>=10000) from numbers(12000)";
2031+
Map<ClickHouseOption, Object> options = new HashMap<>();
20292032
try (ClickHouseClient client = getClient();
20302033
ClickHouseResponse resp = newRequest(client, server)
2031-
.format(ClickHouseFormat.RowBinaryWithNamesAndTypes)
2034+
.format(ClickHouseFormat.TabSeparated)
20322035
.query(query).executeAndWait()) {
2033-
for (ClickHouseRecord r : resp.records()) {
2034-
// does not work which may relate to deserialization failure
2035-
// java.lang.AssertionError: expected [99764115] but found [4121673519155408707]
2036-
// Assert.assertEquals(r.getValue(0).asLong(), count++);
2037-
Assert.assertTrue((count = r.getValue(0).asLong()) >= 0);
2038-
}
20392036
Assert.fail("Query should be terminated before all rows returned");
20402037
} catch (UncheckedIOException e) {
20412038
Assert.assertTrue(e.getCause() instanceof IOException,
20422039
"Should end up with IOException due to deserialization failure");
2040+
} catch (ClickHouseException e) {
2041+
Assert.assertEquals(e.getErrorCode(), 395, "Expected error code 395 but we got: " + e.getErrorCode());
20432042
}
2044-
2045-
Assert.assertNotEquals(count, 0L, "Should have read at least one record");
20462043
}
20472044

20482045
@Test(groups = "integration")

0 commit comments

Comments
 (0)