Skip to content

Commit 7eb28e5

Browse files
authored
Merge pull request #2584 from ClickHouse/upgrade_ch_versions
[REPO] Upgrade ch versions to latest LTS
2 parents b319fd6 + 99b6f5d commit 7eb28e5

File tree

7 files changed

+66
-60
lines changed

7 files changed

+66
-60
lines changed

.github/workflows/analysis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ on:
2828
required: false
2929

3030
env:
31-
PREFERRED_LTS_VERSION: "24.3"
31+
PREFERRED_LTS_VERSION: "25.3"
3232
PR_NUMBER: ${{ github.event.pull_request.number || '' }}
3333

3434
jobs:

.github/workflows/benchmarks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ on:
1212

1313
env:
1414
CHC_BRANCH: "main"
15-
CH_VERSION: "24.8"
15+
CH_VERSION: "25.3"
1616
JAVA_VERSION: 17
1717

1818
concurrency:

.github/workflows/build.yml

Lines changed: 48 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ concurrency:
3232
cancel-in-progress: true
3333

3434
env:
35-
PREFERRED_LTS_VERSION: "24.3"
35+
PREFERRED_LTS_VERSION: "25.3"
3636

3737
jobs:
3838
compile:
@@ -66,44 +66,44 @@ jobs:
6666
if [ -e $d/gradlew ]; then cd $d && ./gradlew clean build; fi;
6767
done
6868
69-
test-multi-env:
70-
needs: compile
71-
strategy:
72-
matrix:
73-
# https://whichjdk.com/
74-
# https://github.com/actions/setup-java/blob/main/docs/advanced-usage.md#selecting-a-java-distribution
75-
# add "corretto", "liberica", "microsoft", "zulu" only when needed
76-
dist: ["temurin"]
77-
# fix issue on "macos-latest", "windows-latest"
78-
os: ["ubuntu-latest"]
79-
fail-fast: false
80-
runs-on: ${{ matrix.os }}
81-
timeout-minutes: 10
82-
name: ${{ matrix.dist }} JDK 17 on ${{ matrix.os }}
83-
steps:
84-
- name: Check out repository
85-
uses: actions/checkout@v4
86-
- name: Check out PR
87-
run: |
88-
git fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 \
89-
origin pull/${{ github.event.inputs.pr }}/merge:merged-pr && git checkout merged-pr
90-
if: github.event.inputs.pr != ''
91-
- name: Install JDK 17 and Maven
92-
uses: actions/setup-java@v4
93-
with:
94-
distribution: ${{ matrix.dist }}
95-
java-version: 17
96-
cache: "maven"
97-
- name: Test libraries
98-
run: mvn --batch-mode --no-transfer-progress -Dj8 -DskipITs verify
99-
- name: Upload test results
100-
uses: actions/upload-artifact@v4
101-
if: failure()
102-
with:
103-
name: result ${{ github.job }}
104-
path: |
105-
**/target/failsafe-reports
106-
**/target/surefire-reports
69+
# test-multi-env:
70+
# needs: compile
71+
# strategy:
72+
# matrix:
73+
# # https://whichjdk.com/
74+
# # https://github.com/actions/setup-java/blob/main/docs/advanced-usage.md#selecting-a-java-distribution
75+
# # add "corretto", "liberica", "microsoft", "zulu" only when needed
76+
# dist: ["temurin"]
77+
# # fix issue on "macos-latest", "windows-latest"
78+
# os: ["ubuntu-latest"]
79+
# fail-fast: false
80+
# runs-on: ${{ matrix.os }}
81+
# timeout-minutes: 10
82+
# name: ${{ matrix.dist }} JDK 17 on ${{ matrix.os }}
83+
# steps:
84+
# - name: Check out repository
85+
# uses: actions/checkout@v4
86+
# - name: Check out PR
87+
# run: |
88+
# git fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 \
89+
# origin pull/${{ github.event.inputs.pr }}/merge:merged-pr && git checkout merged-pr
90+
# if: github.event.inputs.pr != ''
91+
# - name: Install JDK 17 and Maven
92+
# uses: actions/setup-java@v4
93+
# with:
94+
# distribution: ${{ matrix.dist }}
95+
# java-version: 17
96+
# cache: "maven"
97+
# - name: Test libraries
98+
# run: mvn --batch-mode --no-transfer-progress -Dj8 -DskipITs verify
99+
# - name: Upload test results
100+
# uses: actions/upload-artifact@v4
101+
# if: failure()
102+
# with:
103+
# name: result ${{ github.job }}
104+
# path: |
105+
# **/target/failsafe-reports
106+
# **/target/surefire-reports
107107

108108
test-native-image:
109109
runs-on: ubuntu-latest
@@ -122,8 +122,7 @@ jobs:
122122
uses: graalvm/setup-graalvm@v1
123123
with:
124124
version: "latest"
125-
java-version: "17"
126-
components: "native-image"
125+
java-version: "21"
127126
github-token: ${{ secrets.GITHUB_TOKEN }}
128127
- name: Build native image
129128
run: mvn --batch-mode --no-transfer-progress -Pnative -Dj8 -DskipTests install
@@ -145,7 +144,7 @@ jobs:
145144
matrix:
146145
# most recent LTS releases as well as latest stable builds
147146
# https://github.com/ClickHouse/ClickHouse/pulls?q=is%3Aopen+is%3Apr+label%3Arelease
148-
clickhouse: ["24.3", "24.8", "latest"]
147+
clickhouse: ["25.3", "25.8", "latest"]
149148
project: ["clickhouse-http-client", "client-v2"]
150149
fail-fast: false
151150
timeout-minutes: 15
@@ -200,13 +199,14 @@ jobs:
200199
201200
test-with-cloud:
202201
runs-on: ubuntu-latest
203-
needs: compile
202+
needs: test-jdbc-driver
204203
strategy:
205204
matrix:
206205
# most recent LTS releases as well as latest stable builds
207206
# https://github.com/ClickHouse/ClickHouse/pulls?q=is%3Aopen+is%3Apr+label%3Arelease
208207
clickhouse: ["cloud"]
209-
project: ["clickhouse-http-client", "clickhouse-jdbc", "client-v2", "jdbc-v2"]
208+
# project: ["clickhouse-http-client", "clickhouse-jdbc", "client-v2", "jdbc-v2"]
209+
project: ["client-v2", "jdbc-v2"]
210210
fail-fast: false
211211
timeout-minutes: 20
212212
name: ${{ matrix.project }} + CH ${{ matrix.clickhouse }}
@@ -265,10 +265,10 @@ jobs:
265265
266266
test-jdbc-driver:
267267
runs-on: ubuntu-latest
268-
needs: compile
268+
needs: test-java-client
269269
strategy:
270270
matrix:
271-
clickhouse: ["24.3", "24.8", "latest"]
271+
clickhouse: ["25.3", "25.8", "latest"]
272272
# here http, http_client and apache_http_client represent different value of http_connection_provider
273273
# protocol: ["http", "http_client", "apache_http_client"]
274274
protocol: ["apache_http_client"]
@@ -328,10 +328,10 @@ jobs:
328328
329329
test-r2dbc-driver:
330330
runs-on: ubuntu-latest
331-
needs: compile
331+
needs: test-jdbc-driver
332332
strategy:
333333
matrix:
334-
clickhouse: ["24.3", "24.8", "latest"]
334+
clickhouse: ["25.3", "25.8", "latest"]
335335
# grpc is not fully supported, and http_client and apache_http_client do not work in CI environment(due to limited threads?)
336336
protocol: ["http"]
337337
r2dbc: ["1.0.0.RELEASE", "0.9.1.RELEASE"]

.github/workflows/nightly.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ on:
1313
env:
1414
CHC_BRANCH: "main"
1515
# CHC_VERSION: "0.9.0"
16-
CH_VERSION: "24.8"
16+
CH_VERSION: "25.3"
1717

1818
jobs:
1919
nightly:

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
required: true
99

1010
env:
11-
CH_VERSION: "24.8"
11+
CH_VERSION: "25.3"
1212

1313
jobs:
1414
release:

.github/workflows/run_examples.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
ch_version:
77
description: ClickHouse Version
88
required: false
9-
default: 24.8
9+
default: 25.8
1010
client_version:
1111
description: Build Type
1212
type: choice

client-v2/src/test/java/com/clickhouse/client/datatypes/DataTypeTests.java

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -830,9 +830,12 @@ private void testDynamicWith(String withWhat, Object[] values, String[] expected
830830

831831
String table = "test_dynamic_with_" + withWhat;
832832
client.execute("DROP TABLE IF EXISTS " + table).get();
833-
client.execute(tableDefinition(table, "rowId Int32", "field Dynamic"),
834-
(CommandSettings) new CommandSettings().serverSetting("allow_experimental_dynamic_type", "1")
835-
.serverSetting("allow_experimental_time_time64_type", "1")).get();
833+
834+
CommandSettings createTableSettings = (CommandSettings) new CommandSettings().serverSetting("allow_experimental_dynamic_type", "1");
835+
if (isVersionMatch("[25.6,)")) {
836+
createTableSettings.serverSetting("allow_experimental_time_time64_type", "1"); // time64 was introduced in 25.6
837+
}
838+
client.execute(tableDefinition(table, "rowId Int32", "field Dynamic"),createTableSettings).get();
836839

837840
client.register(DTOForDynamicPrimitivesTests.class, client.getTableSchema(table));
838841

@@ -858,10 +861,13 @@ private void testVariantWith(String withWhat, String[] fields, Object[] values,
858861
actualFields[0] = "rowId Int32";
859862
System.arraycopy(fields, 0, actualFields, 1, fields.length);
860863
client.execute("DROP TABLE IF EXISTS " + table).get();
861-
client.execute(tableDefinition(table, actualFields),
862-
(CommandSettings) new CommandSettings()
863-
.serverSetting("allow_experimental_variant_type", "1")
864-
.serverSetting("allow_experimental_time_time64_type", "1")).get();
864+
865+
866+
CommandSettings createTableSettings = (CommandSettings) new CommandSettings().serverSetting("allow_experimental_variant_type", "1");
867+
if (isVersionMatch("[25.6,)")) {
868+
createTableSettings.serverSetting("allow_experimental_time_time64_type", "1"); // time64 was introduced in 25.6
869+
}
870+
client.execute(tableDefinition(table, actualFields),createTableSettings).get();
865871

866872
client.register(DTOForVariantPrimitivesTests.class, client.getTableSchema(table));
867873

0 commit comments

Comments
 (0)