Skip to content

Commit 8136f64

Browse files
author
Paultagoras
committed
Adjusting to reduce lines since we reuse
1 parent 7fa62c8 commit 8136f64

File tree

2 files changed

+2
-17
lines changed

2 files changed

+2
-17
lines changed

client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/SerializerUtils.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -80,25 +80,19 @@ public static void serializeData(OutputStream stream, Object value, ClickHouseCo
8080
serializeTupleData(stream, value, GEO_POINT_TUPLE);
8181
break;
8282
case Ring:
83-
value = value instanceof ClickHouseGeoRingValue ? ((ClickHouseGeoRingValue)value).getValue() : value;
84-
serializeArrayData(stream, value, GEO_RING_ARRAY);
85-
break;
8683
case LineString:
8784
value = value instanceof ClickHouseGeoRingValue ? ((ClickHouseGeoRingValue)value).getValue() : value;
88-
serializeArrayData(stream, value, GEO_LINE_ARRAY);
85+
serializeArrayData(stream, value, GEO_RING_ARRAY);
8986
break;
9087
case Polygon:
88+
case MultiLineString:
9189
value = value instanceof ClickHouseGeoPolygonValue ? ((ClickHouseGeoPolygonValue)value).getValue() : value;
9290
serializeArrayData(stream, value, GEO_POLYGON_ARRAY);
9391
break;
9492
case MultiPolygon:
9593
value = value instanceof ClickHouseGeoMultiPolygonValue ? ((ClickHouseGeoMultiPolygonValue)value).getValue() : value;
9694
serializeArrayData(stream, value, GEO_MULTI_POLYGON_ARRAY);
9795
break;
98-
case MultiLineString:
99-
value = value instanceof ClickHouseGeoMultiPolygonValue ? ((ClickHouseGeoMultiPolygonValue)value).getValue() : value;
100-
serializeArrayData(stream, value, GEO_MULTI_LINE_ARRAY);
101-
break;
10296
case Dynamic:
10397
ClickHouseColumn typeColumn = valueToColumnForDynamicType(value);
10498
writeDynamicTypeTag(stream, typeColumn);
@@ -686,9 +680,7 @@ private static void serializerVariant(OutputStream out, ClickHouseColumn column,
686680
}
687681

688682
private static final ClickHouseColumn GEO_POINT_TUPLE = ClickHouseColumn.parse("geopoint Tuple(Float64, Float64)").get(0);
689-
private static final ClickHouseColumn GEO_LINE_ARRAY = ClickHouseColumn.parse("geoline Array(Tuple(Float64, Float64))").get(0);
690683
private static final ClickHouseColumn GEO_RING_ARRAY = ClickHouseColumn.parse("georing Array(Tuple(Float64, Float64))").get(0);
691-
private static final ClickHouseColumn GEO_MULTI_LINE_ARRAY = ClickHouseColumn.parse("geomultiline Array(Array(Tuple(Float64, Float64)))").get(0);
692684
private static final ClickHouseColumn GEO_POLYGON_ARRAY = ClickHouseColumn.parse("geopolygin Array(Array(Tuple(Float64, Float64)))").get(0);
693685
private static final ClickHouseColumn GEO_MULTI_POLYGON_ARRAY = ClickHouseColumn.parse("geomultipolygin Array(Array(Array(Tuple(Float64, Float64))))").get(0);
694686

client-v2/src/test/java/com/clickhouse/client/datatypes/RowBinaryFormatWriterTest.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,24 +25,17 @@
2525
import java.math.BigInteger;
2626
import java.net.Inet4Address;
2727
import java.net.Inet6Address;
28-
import java.time.Duration;
2928
import java.time.ZonedDateTime;
30-
import java.time.temporal.ChronoUnit;
31-
import java.time.temporal.TemporalUnit;
3229
import java.util.ArrayList;
3330
import java.util.Arrays;
3431
import java.util.HashMap;
3532
import java.util.List;
3633
import java.util.Map;
37-
import java.util.Objects;
3834
import java.util.Random;
3935
import java.util.UUID;
4036
import java.util.concurrent.TimeUnit;
4137

42-
import static com.clickhouse.data.ClickHouseDataType.Decimal;
4338
import static org.testng.Assert.assertEquals;
44-
import static org.testng.Assert.assertNull;
45-
import static org.testng.Assert.assertTrue;
4639

4740
public class RowBinaryFormatWriterTest extends BaseIntegrationTest {
4841
private Client client;

0 commit comments

Comments
 (0)