Skip to content

Commit 8983054

Browse files
committed
replace brackets with constants
1 parent a4f09d9 commit 8983054

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

jdbc-v2/src/main/java/com/clickhouse/jdbc/PreparedStatementImpl.java

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -756,6 +756,9 @@ private String encodeObject(Object x) throws SQLException {
756756

757757
private static final char QUOTE = '\'';
758758

759+
private static final char O_BRACKET = '[';
760+
private static final char C_BRACKET = ']';
761+
759762
private String encodeObject(Object x, Long length) throws SQLException {
760763
LOG.trace("Encoding object: {}", x);
761764

@@ -788,20 +791,20 @@ private String encodeObject(Object x, Long length) throws SQLException {
788791
return QUOTE + ((InetAddress) x).getHostAddress() + QUOTE;
789792
} else if (x instanceof java.sql.Array) {
790793
StringBuilder listString = new StringBuilder();
791-
listString.append('[');
794+
listString.append(O_BRACKET);
792795
appendArrayElements((Object[]) ((Array) x).getArray(), listString);
793-
listString.append(']');
796+
listString.append(C_BRACKET);
794797

795798
return listString.toString();
796799
} else if (x instanceof Object[]) {
797800
StringBuilder arrayString = new StringBuilder();
798-
arrayString.append('[');
801+
arrayString.append(O_BRACKET);
799802
appendArrayElements((Object[]) x, arrayString);
800-
arrayString.append(']');
803+
arrayString.append(C_BRACKET);
801804
return arrayString.toString();
802805
} else if (x.getClass().isArray()) {
803806
StringBuilder listString = new StringBuilder();
804-
listString.append('[');
807+
listString.append(O_BRACKET);
805808
if (x.getClass().getComponentType().isPrimitive()) {
806809
int len = java.lang.reflect.Array.getLength(x);
807810
for (int i = 0; i < len; i++) {
@@ -813,20 +816,20 @@ private String encodeObject(Object x, Long length) throws SQLException {
813816
} else {
814817
appendArrayElements((Object[]) x, listString);
815818
}
816-
listString.append(']');
819+
listString.append(C_BRACKET);
817820

818821
return listString.toString();
819822
} else if (x instanceof Collection) {
820823
StringBuilder listString = new StringBuilder();
821-
listString.append('[');
824+
listString.append(O_BRACKET);
822825
Collection<?> collection = (Collection<?>) x;
823826
for (Object item : collection) {
824827
listString.append(encodeObject(item)).append(',');
825828
}
826829
if (!collection.isEmpty()) {
827830
listString.setLength(listString.length() - 1);
828831
}
829-
listString.append(']');
832+
listString.append(C_BRACKET);
830833

831834
return listString.toString();
832835
} else if (x instanceof Map) {

0 commit comments

Comments
 (0)