added test for DriverProperties.RESULTSET_AUTO_CLOSE

Author: chernser

jdbc-v2/src/main/java/com/clickhouse/jdbc/DriverProperties.java

@@ -46,7 +46,7 @@ public enum DriverProperties {
     /**
      *  Enables closing result set before
      */
-    RESULTSET_AUTO_CLOSE("jdbc_resultset_auto_close", String.valueOf(Boolean.FALSE)),
+    RESULTSET_AUTO_CLOSE("jdbc_resultset_auto_close", String.valueOf(Boolean.TRUE)),
 
     /**
      * Enables using server property `max_result_rows` ({@link ServerSettings#MAX_RESULT_ROWS} to limit number of rows returned by query.

jdbc-v2/src/main/java/com/clickhouse/jdbc/StatementImpl.java

@@ -43,7 +43,7 @@ public class StatementImpl implements Statement, JdbcV2Wrapper {
     protected volatile String lastQueryId;
     private long maxRows;
     private boolean closeOnCompletion;
-    private boolean resultSetAutoClose;
+    private final boolean resultSetAutoClose;
     private int maxFieldSize;
     private boolean escapeProcessingEnabled;
 

jdbc-v2/src/test/java/com/clickhouse/jdbc/StatementTest.java

@@ -511,9 +511,8 @@ public void testWithIPs() throws Exception {
         }
     }
 
-    @Test
+    @Test(groups = {"integration"})
     public void testConnectionExhaustion() throws Exception {
-
         int maxNumConnections = 3;
         Properties properties = new Properties();
         properties.put(ClientConfigProperties.HTTP_MAX_OPEN_CONNECTIONS.getKey(), "" + maxNumConnections);
@@ -526,6 +525,20 @@ public void testConnectionExhaustion() throws Exception {
                 }
             }
         }
+
+        properties.put(DriverProperties.RESULTSET_AUTO_CLOSE.getKey(), "false");
+        try (Connection conn = getJdbcConnection(properties)) {
+            try (Statement stmt = conn.createStatement()) {
+                try {
+                    for (int i = 0; i < maxNumConnections * 2; i++) {
+                        stmt.executeQuery("SELECT number FROM system.numbers LIMIT 100");
+                    }
+                    fail("Exception expected");
+                } catch (SQLException e) {
+                    // ignore
+                }
+            }
+        }
     }
 
     @Test(groups = {"integration"})