Skip to content

Commit 91f41ae

Browse files
committed
added a few test for db metadata
1 parent e098269 commit 91f41ae

File tree

2 files changed

+24
-1
lines changed

2 files changed

+24
-1
lines changed

jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1345,7 +1345,6 @@ public int getDatabaseMajorVersion() throws SQLException {
13451345
try {
13461346
return Integer.parseInt(version.split("\\.")[0]);
13471347
} catch (NumberFormatException e) {
1348-
log.error("Failed to parse major version from server version: " + version, e);
13491348
throw new SQLException("Failed to parse major version from server version: " + version, ExceptionUtils.SQL_STATE_CLIENT_ERROR, e);
13501349
}
13511350
}

jdbc-v2/src/test/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataTest.java

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1103,4 +1103,28 @@ private void assertProcedureColumns(ResultSetMetaData rsmd, List<String> expecte
11031103
}
11041104
}
11051105

1106+
1107+
1108+
@Test(groups = {"integration"})
1109+
public void testGetDatabaseMajorVersion() throws Exception {
1110+
try (Connection conn = getJdbcConnection()) {
1111+
DatabaseMetaData dbmd = conn.getMetaData();
1112+
int majorVersion = dbmd.getDatabaseMajorVersion();
1113+
String version = getServerVersion();
1114+
int majorVersionOfServer = Integer.parseInt(version.split("\\.")[0]);
1115+
assertEquals(majorVersion, majorVersionOfServer, "Major version");
1116+
}
1117+
}
1118+
1119+
1120+
@Test(groups = {"integration"})
1121+
public void testGetDatabaseMinorVersion() throws Exception {
1122+
try (Connection conn = getJdbcConnection()) {
1123+
DatabaseMetaData dbmd = conn.getMetaData();
1124+
int minorVersion = dbmd.getDatabaseMinorVersion();
1125+
String version = getServerVersion();
1126+
int minorVersionOfServer = Integer.parseInt(version.split("\\.")[1]);
1127+
assertEquals(minorVersion, minorVersionOfServer, "Minor version");
1128+
}
1129+
}
11061130
}

0 commit comments

Comments
 (0)