Added more tests for other metadata columns

Author: chernser

clickhouse-data/src/main/java/com/clickhouse/data/ClickHouseDataType.java

@@ -108,7 +108,7 @@ public enum ClickHouseDataType {
     JSON(Object.class, false, false, false, 0, 0, 0, 0, 0, true, 0x30),
     @Deprecated
     Object(Object.class, true, true, false, 0, 0, 0, 0, 0, true),
-    String(String.class, false, false, false, 0, 0, 0, 0, 0, false, 0x15, "BINARY LARGE OBJECT", "BINARY VARYING", "BLOB",
+    String(String.class, false, true, false, 0, 0, 0, 0, 0, false, 0x15, "BINARY LARGE OBJECT", "BINARY VARYING", "BLOB",
             "BYTEA", "CHAR", "CHAR LARGE OBJECT", "CHAR VARYING", "CHARACTER", "CHARACTER LARGE OBJECT",
             "CHARACTER VARYING", "CLOB", "GEOMETRY", "LONGBLOB", "LONGTEXT", "MEDIUMBLOB", "MEDIUMTEXT",
             "NATIONAL CHAR", "NATIONAL CHAR VARYING", "NATIONAL CHARACTER", "NATIONAL CHARACTER LARGE OBJECT",
@@ -119,8 +119,8 @@ public enum ClickHouseDataType {
     Nested(Object.class, true, true, false, 0, 0, 0, 0, 0, true, 0x2F),
     Tuple(List.class, true, true, false, 0, 0, 0, 0, 0, true, 0x1F),
     Nothing(Object.class, false, true, false, 0, 0, 0, 0, 0, true, 0x00),
-    LowCardinality(Object.class, true, false, false, 0, 0, 0, 0, 0, true, 0x26),
-    Nullable( Object.class, true, false, false, 0, 0, 0, 0, 0, true, 0x23),
+    LowCardinality(Object.class, true, true, false, 0, 0, 0, 0, 0, true, 0x26),
+    Nullable( Object.class, true, true, false, 0, 0, 0, 0, 0, true, 0x23),
     SimpleAggregateFunction(String.class, true, true, false, 0, 0, 0, 0, 0, false, 0x2E),
     // implementation-defined intermediate state
     AggregateFunction(String.class, true, true, false, 0, 0, 0, 0, 0, true),

jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaData.java

@@ -1029,9 +1029,9 @@ private static String getDataTypeInfoSql() {
                 "NULL AS LITERAL_SUFFIX, " +
                 "NULL AS CREATE_PARAMS, " +
                 "name AS NULLABLE, " + // passing type name to map for nullable
-                "not(dt.case_insensitive) AS CASE_SENSITIVE, " +
+                "not(dt.case_insensitive)::Boolean AS CASE_SENSITIVE, " +
                 java.sql.DatabaseMetaData.typeSearchable + " AS SEARCHABLE, " +
-                "attrs.c3 AS UNSIGNED_ATTRIBUTE, " +
+                "not(attrs.c3)::Boolean AS UNSIGNED_ATTRIBUTE, " +
                 "false AS FIXED_PREC_SCALE, " +
                 "false AS AUTO_INCREMENT, " +
                 "name AS LOCAL_TYPE_NAME, " +

jdbc-v2/src/test/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataTest.java

@@ -240,17 +240,39 @@ public void testGetTypeInfo() throws Exception {
                 while (rs.next()) {
                     count++;
                     ClickHouseDataType dataType = ClickHouseDataType.of( rs.getString("TYPE_NAME"));
+                    System.out.println("> " + dataType);
                     assertEquals(ClickHouseDataType.of(rs.getString(1)), dataType);
                     assertEquals(rs.getInt("DATA_TYPE"),
                             (int) JdbcUtils.convertToSqlType(dataType).getVendorTypeNumber(),
                             "Type mismatch for " + dataType.name() + ": expected " +
                                     JdbcUtils.convertToSqlType(dataType).getVendorTypeNumber() +
                                     " but was " + rs.getInt("DATA_TYPE") + " for TYPE_NAME: " + rs.getString("TYPE_NAME"));
+
+                    assertEquals(rs.getInt("PRECISION"), dataType.getMaxPrecision());
+                    assertNull(rs.getString("LITERAL_PREFIX"));
+                    assertNull(rs.getString("LITERAL_SUFFIX"));
+                    assertEquals(rs.getInt("MINIMUM_SCALE"), dataType.getMinScale());
+                    assertEquals(rs.getInt("MAXIMUM_SCALE"), dataType.getMaxScale());
+                    assertNull(rs.getString("CREATE_PARAMS"));
+
                     if (dataType == ClickHouseDataType.Nullable || dataType == ClickHouseDataType.Dynamic) {
                         assertEquals( rs.getShort("NULLABLE"), DatabaseMetaData.typeNullable);
                     } else {
                         assertEquals(rs.getShort("NULLABLE"), DatabaseMetaData.typeNoNulls);
                     }
+
+                    if (dataType != ClickHouseDataType.Enum) {
+                        assertEquals(rs.getBoolean("CASE_SENSITIVE"), dataType.isCaseSensitive());
+                    }
+                    assertEquals(rs.getInt("SEARCHABLE"), DatabaseMetaData.typeSearchable);
+                    assertEquals(rs.getBoolean("UNSIGNED_ATTRIBUTE"), !dataType.isSigned());
+                    assertEquals(rs.getBoolean("FIXED_PREC_SCALE"), false);
+                    assertFalse(rs.getBoolean("AUTO_INCREMENT"));
+                    assertEquals(rs.getString("LOCAL_TYPE_NAME"), dataType.name());
+                    assertEquals(rs.getInt("MINIMUM_SCALE"), dataType.getMinScale());
+                    assertEquals(rs.getInt("MAXIMUM_SCALE"), dataType.getMaxScale());
+                    assertEquals(rs.getInt("SQL_DATA_TYPE"), 0);
+                    assertEquals(rs.getInt("SQL_DATETIME_SUB"), 0);
                 }
 
                 assertTrue(count > 10, "At least 10 types should be returned but was " + count);