Skip to content

Commit a814fa3

Browse files
committed
updated tests where exception expected but now implemented
1 parent 5b557ff commit a814fa3

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

jdbc-v2/src/test/java/com/clickhouse/jdbc/ConnectionTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -397,10 +397,6 @@ public void testCreateArray() throws SQLException {
397397
assertEquals(arrayValue.getBaseType(), JDBCType.OTHER.getVendorTypeNumber());
398398
assertThrows(SQLFeatureNotSupportedException.class, () -> arrayValue.getArray(null));
399399
assertThrows(SQLFeatureNotSupportedException.class, () -> arrayValue.getArray(0, 1, null));
400-
assertThrows(SQLFeatureNotSupportedException.class, arrayValue::getResultSet);
401-
assertThrows(SQLFeatureNotSupportedException.class, () -> arrayValue.getResultSet(0, 1));
402-
assertThrows(SQLFeatureNotSupportedException.class, () -> arrayValue.getResultSet(null));
403-
assertThrows(SQLFeatureNotSupportedException.class, () -> arrayValue.getResultSet(0, 1, null));
404400

405401
Assert.expectThrows(SQLException.class, () -> arrayValue.getArray(-1, 1));
406402
Assert.expectThrows(SQLException.class, () -> arrayValue.getArray(0, -1));

jdbc-v2/src/test/java/com/clickhouse/jdbc/DataTypeTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -820,11 +820,11 @@ public void testFloatTypes() throws SQLException {
820820
try (Statement stmt = conn.createStatement()) {
821821
try (ResultSet rs = stmt.executeQuery("SELECT * FROM test_floats ORDER BY order")) {
822822
assertTrue(rs.next());
823-
assertEquals(rs.getObject("float32"), -3.402823E38d);
823+
assertEquals(rs.getObject("float32"), -3.402823E38f);
824824
assertEquals(rs.getObject("float64"), Double.valueOf(-1.7976931348623157E308));
825825

826826
assertTrue(rs.next());
827-
assertEquals(rs.getObject("float32"), 3.402823E38d);
827+
assertEquals(rs.getObject("float32"), 3.402823E38f);
828828
assertEquals(rs.getObject("float64"), Double.valueOf(1.7976931348623157E308));
829829

830830
assertTrue(rs.next());

jdbc-v2/src/test/java/com/clickhouse/jdbc/ResultSetImplTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import static org.testng.Assert.assertEquals;
2929
import static org.testng.Assert.assertTrue;
3030

31+
@Test(groups = "integration")
3132
public class ResultSetImplTest extends JdbcIntegrationTest {
3233

3334
@Test(groups = "integration")
@@ -361,7 +362,7 @@ public void testGetMetadata() throws SQLException {
361362
}
362363
}
363364

364-
@Test
365+
@Test(groups = {"integration"})
365366
public void testGetResultSetFromArray() throws Exception {
366367

367368
try (Connection conn = getJdbcConnection(); Statement stmt = conn.createStatement()) {

0 commit comments

Comments
 (0)