Skip to content

Commit a9157f6

Browse files
authored
Merge pull request #2473 from ClickHouse/jdbc_fix_parser_issue
[jdbc-v2] Fix parser issues
2 parents d475e82 + 2dc396f commit a9157f6

File tree

12 files changed

+441
-35
lines changed

12 files changed

+441
-35
lines changed

.github/workflows/analysis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,14 @@ jobs:
9292
- name: Build and install
9393
run: |
9494
find . -type f -name "simplelogger.*" -exec rm -fv '{}' \;
95-
mvn -q --batch-mode -DclickhouseVersion=$PREFERRED_LTS_VERSION \
95+
mvn -q --no-transfer-progress --batch-mode -DclickhouseVersion=$PREFERRED_LTS_VERSION \
9696
-DskipTests install
9797
- name: Analyze
9898
env:
9999
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
100100
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
101101
run: |
102-
mvn --batch-mode -DclickhouseVersion=$PREFERRED_LTS_VERSION \
102+
mvn -fn --no-transfer-progress --batch-mode -DclickhouseVersion=$PREFERRED_LTS_VERSION \
103103
-Panalysis verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=ClickHouse_clickhouse-java
104104
continue-on-error: true
105105
- name: Generate and post coverage report

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ java.prof
4848
jmh-result.*
4949
profile.html
5050
jdbc-v2/gen
51+
jdbc-v2/src/main/antlr4/com/clickhouse/jdbc/internal/gen
52+
jdbc-v2/src/main/antlr4/com/clickhouse/jdbc/internal/ClickHouseLexer.tokens
5153

5254
# Shell scripts
5355
*.sh

client-v2/src/main/java/com/clickhouse/client/api/ClientConfigProperties.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,9 @@ public static Map<String, Object> parseConfigMap(Map<String, String> configMap)
311311
}
312312
}
313313

314-
LOG.warn("Unknown and unmapped config properties: {}", tmpMap);
314+
if (!tmpMap.isEmpty()) {
315+
LOG.warn("Unknown and unmapped config properties: {}", tmpMap);
316+
}
315317

316318
return parsedConfig;
317319
}

jdbc-v2/src/main/antlr4/com/clickhouse/jdbc/internal/ClickHouseLexer.g4

Lines changed: 32 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ MONTH : M O N T H;
135135
MOVE : M O V E;
136136
MUTATION : M U T A T I O N;
137137
NAN_SQL : N A N; // conflicts with macro NAN
138-
NAME : N A M E;
138+
NAME : N A M E;
139139
NO : N O;
140140
NO_PASSWORD : N O '_' P A S S W O R D;
141141
NONE : N O N E;
@@ -228,6 +228,37 @@ WHERE : W H E R E;
228228
WINDOW : W I N D O W;
229229
WITH : W I T H;
230230
YEAR : Y E A R | Y Y Y Y;
231+
QUOTA : Q U O T A;
232+
ACCESS : A C C E S S;
233+
GRANT : G R A N T;
234+
WAIT : W A I T;
235+
CLEANUP : C L E A N U P;
236+
DEFINER : D E F I N E R;
237+
RESTART : R E S T A R T;
238+
SOURCES : S O U R C E S;
239+
AZURE : A Z U R E;
240+
FILE : F I L E;
241+
HDFS : H D F S;
242+
HIVE : H I V E;
243+
JDBC : J D B C;
244+
KAFKA : K A F K A;
245+
MONGO : M O N G O;
246+
MYSQL : M Y S Q L;
247+
NATS : N A T S;
248+
ODBC : O D B C;
249+
POSTGRES : P O S T G R E S;
250+
RABBITMQ : R A B B I T M Q;
251+
REDIS : R E D I S;
252+
REMOTE : R E M O T E;
253+
S3 : S '3';
254+
SQLITE : S Q L I T E;
255+
URL : U R L;
256+
LOADING : L O A D I N G;
257+
VIRTUAL : V I R T U A L;
258+
VIEWS : V I E W S;
259+
POLICY : P O L I C Y;
260+
PERMISSIVE : P E R M I S S I V E;
261+
RESTRICTIVE : R E S T R I C T I V E;
231262

232263
JSON_FALSE : 'false';
233264
JSON_TRUE : 'true';

0 commit comments

Comments
 (0)