Skip to content

Commit b2aae91

Browse files
authored
Merge pull request #2234 from ClickHouse/perf_blackhole_test
[perf] Added a blackhole to query tests
2 parents 0ea28d4 + 5bf10b9 commit b2aae91

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

performance/src/test/com/clickhouse/benchmark/clients/QueryClient.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import org.openjdk.jmh.annotations.Benchmark;
1111
import org.openjdk.jmh.annotations.Scope;
1212
import org.openjdk.jmh.annotations.State;
13+
import org.openjdk.jmh.infra.Blackhole;
1314
import org.slf4j.Logger;
1415
import org.slf4j.LoggerFactory;
1516

@@ -20,7 +21,7 @@ public class QueryClient extends BenchmarkBase {
2021
private static final Logger LOGGER = LoggerFactory.getLogger(QueryClient.class);
2122

2223
@Benchmark
23-
public void queryV1(DataState dataState) {
24+
public void queryV1(DataState dataState, Blackhole blackhole) {
2425
try {
2526
try (ClickHouseResponse response = clientV1.read(getServer())
2627
.query(BenchmarkRunner.getSelectQuery(dataState.tableNameFilled))
@@ -29,7 +30,7 @@ public void queryV1(DataState dataState) {
2930
.executeAndWait()) {
3031
for (ClickHouseRecord record: response.records()) {//Compiler optimization avoidance
3132
for (int i = 0; i < dataState.dataSet.getSchema().getColumns().size(); i++) {
32-
isNotNull(record.getValue(i), false);
33+
blackhole.consume(record.getValue(i).asObject());
3334
}
3435
}
3536
}
@@ -39,13 +40,13 @@ public void queryV1(DataState dataState) {
3940
}
4041

4142
@Benchmark
42-
public void queryV2(DataState dataState) {
43+
public void queryV2(DataState dataState, Blackhole blackhole) {
4344
try {
4445
try(QueryResponse response = clientV2.query(BenchmarkRunner.getSelectQuery(dataState.tableNameFilled)).get()) {
4546
ClickHouseBinaryFormatReader reader = clientV2.newBinaryFormatReader(response);
4647
while (reader.next() != null) {//Compiler optimization avoidance
4748
for (int i = 1; i <= dataState.dataSet.getSchema().getColumns().size(); i++) {
48-
isNotNull(reader.readValue(1), false);
49+
blackhole.consume(reader.readValue(1));
4950
}
5051
}
5152
}

0 commit comments

Comments
 (0)