Removing as this metric should be done at the application layer

Author: Paultagoras

client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java

@@ -115,9 +115,6 @@ public class HttpAPIClientHelper {
 
     private final Set<ClientFaultCause> defaultRetryCauses;
 
-    private AtomicLong requestCount = new AtomicLong(0);
-    private AtomicLong failureCount = new AtomicLong(0);
-
     private String defaultUserAgent;
     private Object metricsRegistry;
     public HttpAPIClientHelper(Map<String, String> configuration, Object metricsRegistry, boolean initSslContext) {
@@ -420,7 +417,6 @@ public ClassicHttpResponse executeRequest(ClickHouseNode server, Map<String, Obj
         HttpClientContext context = HttpClientContext.create();
 
         try {
-            requestCount.incrementAndGet();
             ClassicHttpResponse httpResponse = httpClient.executeOpen(null, req, context);
             boolean serverCompression = MapUtils.getFlag(requestConfig, chConfiguration, ClientConfigProperties.COMPRESS_SERVER_RESPONSE.getKey());
             httpResponse.setEntity(wrapResponseEntity(httpResponse.getEntity(), httpResponse.getCode(), serverCompression, useHttpCompression));
@@ -446,10 +442,6 @@ public ClassicHttpResponse executeRequest(ClickHouseNode server, Map<String, Obj
             LOG.warn("Failed to connect to '{}': {}", server.getHost(), e.getMessage());
             throw new ClientException("Failed to connect", e);
         } catch (ConnectionRequestTimeoutException | ServerException | NoHttpResponseException | ClientException | SocketTimeoutException e) {
-            failureCount.incrementAndGet();
-            if (e instanceof ConnectionRequestTimeoutException || e instanceof SocketTimeoutException) {
-                LOG.warn("Request failed with timeout: {}", req.getConfig().getConnectionRequestTimeout()); // record timeout value
-            }
             throw e;
         } catch (Exception e) {
             throw new ClientException("Failed to execute request", e);
@@ -783,11 +775,6 @@ public void close() {
         httpClient.close(CloseMode.IMMEDIATE);
     }
 
-
-    public long getRequestRatio() {//Metrics
-        return requestCount.get() == 0 ? 0 : Math.round(((float) failureCount.get() / requestCount.get()) * 100);
-    }
-
     /**
      * This factory is used only when no ssl connections are required (no https endpoints).
      * Internally http client would create factory and spend time if no supplied.

client-v2/src/main/java/com/clickhouse/client/api/metrics/MicrometerLoader.java

@@ -28,15 +28,4 @@ public static void applyConnectionMetricsBinder(Object registry, String metricsG
             throw new ClientMisconfigurationException("Unsupported registry type." + registry.getClass());
         }
     }
-
-    public static void applyFailureRatioMetricsBinder(Object registry, String metricsGroupName, HttpAPIClientHelper httpAPIClientHelper) {
-        if (registry instanceof MeterRegistry) {
-            Gauge.builder("httpcomponents.httpclient.request.ratio", httpAPIClientHelper, HttpAPIClientHelper::getRequestRatio)
-                    .description("The ratio of total requests to failures via timeout.")
-                    .tag("httpclient", metricsGroupName)
-                    .register((MeterRegistry) registry);
-        } else {
-            throw new ClientMisconfigurationException("Unsupported registry type." + registry.getClass());
-        }
-    }
 }

client-v2/src/test/java/com/clickhouse/client/metrics/MetricsTest.java

@@ -102,26 +102,4 @@ public void testConnectionTime() throws Exception {
             assertEquals(times.value(), 0);//Second time should be 0
         }
     }
-
-    @Test(groups = { "integration" }, enabled = true)
-    public void testConnectionRatio() throws Exception {
-        ClickHouseNode node = getServer(ClickHouseProtocol.HTTP);
-        boolean isSecure = isCloud();
-
-        try (Client client = new Client.Builder()
-                .addEndpoint(Protocol.HTTP, "192.168.1.1", node.getPort(), isSecure)
-                .setUsername("default")
-                .setPassword(ClickHouseServerForTest.getPassword())
-                .setDefaultDatabase(ClickHouseServerForTest.getDatabase())
-                .setConnectTimeout(5, ChronoUnit.SECONDS)
-                .registerClientMetrics(meterRegistry, "pool-test")
-                .build()) {
-
-            client.ping();
-            Gauge ratio = meterRegistry.get("httpcomponents.httpclient.request.ratio").gauge();
-
-            System.out.println("Ratio: " + ratio.value());
-            Assert.assertTrue(ratio.value() > 99.0);
-        }
-    }
 }

client-v2/src/test/java/com/clickhouse/client/query/QueryTests.java

@@ -2056,10 +2056,7 @@ public void testGettingRowsBeforeLimit() throws Exception {
             Assert.assertEquals(response.getTotalRowsToRead(), expectedTotalRowsToRead);
         }
     }
-
-    static {
-        System.setProperty("org.slf4j.simpleLogger.defaultLogLevel", "DEBUG");
-    }
+    
     @Test(groups = {"integration"})
     public void testEmptyResponse() throws Exception {
         try (QueryResponse response = client.query("SELECT number FROM system.numbers LIMIT 0", new QuerySettings().setFormat(ClickHouseFormat.RowBinary)).get()) {