added as common property

Author: chernser

.github/workflows/analysis.yml

@@ -95,6 +95,6 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         run: |
-          mvn --batch-mode -DclickhouseVersion=$PREFERRED_LTS_VERSION \
+          mvn --batch-mode -DclickhouseVersion=$PREFERRED_LTS_VERSION -Dclient.tests.useNewImplementation=true \
             -Panalysis verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar
         continue-on-error: true

client-v2/src/main/java/com/clickhouse/client/api/Client.java

@@ -756,6 +756,22 @@ public Builder setMaxRetries(int maxRetries) {
             return this;
         }
 
+        /**
+         * Configures client to reuse allocated byte buffers for numbers. It affects how binary format reader is working.
+         * If set to 'true' then {@link  Client#newBinaryFormatReader(QueryResponse)} will construct reader that will
+         * reuse buffers for numbers. It improves performance for large datasets by reducing number of allocations
+         * (therefore GC pressure).
+         * Enabling this feature is safe because each reader suppose to be used by a single thread and readers are not reused.
+         *
+         * Default is false.
+         * @param reuse - if to reuse buffers
+         * @return
+         */
+        public Builder allowBinaryReaderToReuseBuffers(boolean reuse) {
+            this.configuration.put("client_allow_binary_reader_to_reuse_buffers", String.valueOf(reuse));
+            return this;
+        }
+
         public Client build() {
             setDefaults();
 
@@ -869,6 +885,10 @@ private void setDefaults() {
             if (!configuration.containsKey(ClickHouseClientOption.RETRY.getKey())) {
                 setMaxRetries(3);
             }
+
+            if (!configuration.containsKey("client_allow_binary_reader_to_reuse_buffers")) {
+                allowBinaryReaderToReuseBuffers(false);
+            }
         }
     }
 
@@ -1576,8 +1596,7 @@ public CompletableFuture<CommandResponse> execute(String sql) {
     public ClickHouseBinaryFormatReader newBinaryFormatReader(QueryResponse response, TableSchema schema) {
         ClickHouseBinaryFormatReader reader = null;
         // Using caching buffer allocator is risky so this parameter is not exposed to the user
-        boolean useCachingBufferAllocator = Boolean.parseBoolean(
-                configuration.getOrDefault("client_use_caching_buffer_allocator", "false"));
+        boolean useCachingBufferAllocator = MapUtils.getFlag(configuration, "client_allow_binary_reader_to_reuse_buffers");
         BinaryStreamReader.ByteBufferAllocator byteBufferPool = useCachingBufferAllocator ?
                 new BinaryStreamReader.CachingByteBufferAllocator() :
                 new BinaryStreamReader.DefaultByteBufferAllocator();

client-v2/src/test/java/com/clickhouse/client/query/BinaryReadyReusesBuffersTests.java

@@ -0,0 +1,8 @@
+package com.clickhouse.client.query;
+
+public class BinaryReadyReusesBuffersTests extends QueryTests  {
+
+    public BinaryReadyReusesBuffersTests() {
+        super(false, false, true);
+    }
+}

client-v2/src/test/java/com/clickhouse/client/query/QueryTests.java

@@ -1462,7 +1462,7 @@ protected Client.Builder newClient() {
                 .compressClientRequest(false)
                 .compressServerResponse(true)
                 .useHttpCompression(useHttpCompression)
-                .setOption("client_use_caching_buffer_allocator", Boolean.valueOf(usePreallocatedBuffers).toString())
+                .allowBinaryReaderToReuseBuffers(usePreallocatedBuffers)
                 .useNewImplementation(System.getProperty("client.tests.useNewImplementation", "true").equals("true"));
     }
 }