Skip to content

Commit bc1f50d

Browse files
authored
Merge pull request #1785 from ClickHouse/fix_1776
Revert check for updateResult()
2 parents c49d5a2 + ad3863d commit bc1f50d

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/ClickHouseStatementImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ protected ClickHouseResultSet newEmptyResultSet() throws SQLException {
452452
}
453453

454454
protected ResultSet updateResult(ClickHouseSqlStatement stmt, ClickHouseResponse response) throws SQLException {
455-
if (stmt.isQuery()) {
455+
if (stmt.isQuery() || (!stmt.isRecognized() && !response.getColumns().isEmpty())) {
456456
currentUpdateCount = -1L;
457457
currentResult = new ClickHouseResultSet(stmt.getDatabaseOrDefault(getConnection().getCurrentDatabase()),
458458
stmt.getTable(), this, response);

clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/ClickHouseStatementTest.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import java.sql.Connection;
2929
import java.sql.PreparedStatement;
3030
import java.sql.ResultSet;
31+
import java.sql.ResultSetMetaData;
3132
import java.sql.SQLException;
3233
import java.sql.Statement;
3334
import java.sql.Struct;
@@ -1477,4 +1478,19 @@ public void testUseOffsetDateTime() {
14771478
Assert.fail("Failed to create connection", e);
14781479
}
14791480
}
1481+
1482+
1483+
@Test(groups = "integration")
1484+
public void testDescMetadata() {
1485+
try (ClickHouseConnection conn = newConnection();
1486+
ClickHouseStatement stmt = conn.createStatement()) {
1487+
ResultSet rs = stmt.executeQuery("DESC (select timezone(), number FROM system.numbers)");
1488+
rs.next();
1489+
ResultSetMetaData metaData = rs.getMetaData();
1490+
Assert.assertEquals(metaData.getColumnCount(), 7);
1491+
} catch (Exception e) {
1492+
e.printStackTrace();
1493+
Assert.fail("Failed to create connection", e);
1494+
}
1495+
}
14801496
}

0 commit comments

Comments
 (0)