added a test for toKeyValuePairs()

Author: chernser

client-v2/src/main/java/com/clickhouse/client/api/ClientConfigProperties.java

@@ -343,6 +343,8 @@ public static Map<String, Object> parseConfigMap(Map<String, String> configMap)
 
     /**
      * Converts given string to key value pairs.
+     * This is very simple implementation that do not handle edge cases like
+     * {@code k1=v1, ,k2=v2}
      *
      * @param str string
      * @return non-null key value pairs
@@ -393,6 +395,7 @@ public static Map<String, String> toKeyValuePairs(String str) {
     }
 
 
+
     public static String mapToString(Map<?,?> map, Function<Object, String> valueConverter) {
         StringBuilder sb = new StringBuilder();
         for (Map.Entry<?, ?> entry : map.entrySet()) {

client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java

@@ -51,7 +51,7 @@
 
 public abstract class AbstractBinaryFormatReader implements ClickHouseBinaryFormatReader {
 
-    public static final Map<ClickHouseDataType, Class<?>> NO_TYPE_HINT_MAPPING = null;
+    public static final Map<ClickHouseDataType, Class<?>> NO_TYPE_HINT_MAPPING = Collections.emptyMap();
 
     private static final Logger LOG = LoggerFactory.getLogger(AbstractBinaryFormatReader.class);
 

client-v2/src/test/java/com/clickhouse/client/api/ClientConfigPropertiesTest.java

@@ -0,0 +1,34 @@
+package com.clickhouse.client.api;
+
+
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+import java.util.Map;
+
+
+public class ClientConfigPropertiesTest {
+
+    @Test(groups = {"unit"})
+    public void testToKeyValuePairs() {
+
+        Map<String, String> map = ClientConfigProperties.toKeyValuePairs("key1=value1,key2=value2");
+        Assert.assertEquals(map.size(), 2);
+        Assert.assertEquals(map.get("key1"), "value1");
+        Assert.assertEquals(map.get("key2"), "value2");
+
+        map = ClientConfigProperties.toKeyValuePairs("key1=value1, key2 = value2");
+        Assert.assertEquals(map.size(), 2);
+        Assert.assertEquals(map.get("key1"), "value1");
+        Assert.assertEquals(map.get("key2"), "value2");
+
+        map = ClientConfigProperties.toKeyValuePairs("key1");
+        Assert.assertEquals(map.size(), 0);
+
+        // TODO: improve implementation
+//        map = ClientConfigProperties.toKeyValuePairs("key1=value1, ,key2=value2");
+//        Assert.assertEquals(map.size(), 2);
+//        Assert.assertEquals(map.get("key1"), "value1");
+//        Assert.assertEquals(map.get("key2"), "value2");
+    }
+}

jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/JdbcUtils.java

@@ -230,7 +230,6 @@ public static Object convert(Object value, Class<?> type, ClickHouseColumn colum
                 }
                 return new Array(((BinaryStreamReader.ArrayValue) value).asList(), "Object", JDBCType.JAVA_OBJECT.getVendorTypeNumber());
             } else if (type == java.sql.Array.class && value instanceof List<?>) {
-                System.out.println(value);
                 if (column != null && column.getArrayBaseColumn() != null) {
                     return new Array(convertList(((List) value), JdbcUtils.convertToJavaClass(column.getArrayBaseColumn().getDataType())), "Object", JDBCType.JAVA_OBJECT.getVendorTypeNumber());
                 }