Code cleanup

Author: Paultagoras

jdbc-v2/src/main/java/com/clickhouse/jdbc/PreparedStatementImpl.java

@@ -7,14 +7,11 @@
 import java.io.Reader;
 import java.math.BigDecimal;
 import java.net.URL;
-import java.nio.charset.StandardCharsets;
 import java.sql.*;
-import java.time.LocalDateTime;
 import java.time.ZoneId;
 import java.time.format.DateTimeFormatter;
 import java.time.format.DateTimeFormatterBuilder;
 import java.time.temporal.ChronoField;
-import java.time.temporal.TemporalField;
 import java.util.Calendar;
 import java.util.GregorianCalendar;
 
@@ -78,13 +75,13 @@ public void setNull(int parameterIndex, int sqlType) throws SQLException {
     @Override
     public void setBoolean(int parameterIndex, boolean x) throws SQLException {
         checkClosed();
-        parameters[parameterIndex - 1] = x;
+        parameters[parameterIndex - 1] = Boolean.toString(x);
     }
 
     @Override
     public void setByte(int parameterIndex, byte x) throws SQLException {
         checkClosed();
-        parameters[parameterIndex - 1] = x;
+        parameters[parameterIndex - 1] = Byte.toString(x);
     }
 
     @Override
@@ -132,7 +129,7 @@ public void setString(int parameterIndex, String x) throws SQLException {
     @Override
     public void setBytes(int parameterIndex, byte[] x) throws SQLException {
         checkClosed();
-        parameters[parameterIndex - 1] = new String(x, StandardCharsets.UTF_8);
+        throw new SQLFeatureNotSupportedException("Bytes is not yet supported.");
     }
 
     @Override
@@ -265,7 +262,6 @@ public void setTime(int parameterIndex, Time x, Calendar cal) throws SQLExceptio
         ZoneId tz = cal.getTimeZone().toZoneId();
         Calendar c = (Calendar) cal.clone();
         c.setTime(x);
-        System.out.println(String.format("'%s'", TIME_FORMATTER.format(c.toInstant().atZone(tz).toLocalTime())));
         parameters[parameterIndex - 1] = String.format("'%s'", TIME_FORMATTER.format(c.toInstant().atZone(tz).toLocalTime()));
     }
 

jdbc-v2/src/test/java/com/clickhouse/jdbc/PreparedStatementTest.java

@@ -1,5 +1,6 @@
 package com.clickhouse.jdbc;
 
+import org.testng.annotations.Ignore;
 import org.testng.annotations.Test;
 
 import java.sql.Connection;
@@ -142,14 +143,15 @@ public void testSetString() throws Exception {
         }
     }
 
+    @Ignore("Not supported yet")
     @Test
     public void testSetBytes() throws Exception {
         try (Connection conn = getJdbcConnection()) {
             try (PreparedStatement stmt = conn.prepareStatement("SELECT ?")) {
                 stmt.setBytes(1, new byte[] { 1, 2, 3 });
                 try (ResultSet rs = stmt.executeQuery()) {
                     assertTrue(rs.next());
-                    assertEquals(new byte[] { 1, 2, 3 }, rs.getBytes(1));
+                    assertEquals(rs.getBytes(1), new byte[] { 1, 2, 3 });
                     assertFalse(rs.next());
                 }
             }
@@ -173,7 +175,7 @@ public void testSetDate() throws Exception {
     @Test
     public void testSetTime() throws Exception {
         try (Connection conn = getJdbcConnection()) {
-            try (PreparedStatement stmt = conn.prepareStatement("SELECT ?")) {
+            try (PreparedStatement stmt = conn.prepareStatement("SELECT parseDateTime(?, '%H:%i:%s')")) {
                 stmt.setTime(1, java.sql.Time.valueOf("12:34:56"));
                 try (ResultSet rs = stmt.executeQuery()) {
                     assertTrue(rs.next());