Skip to content

Commit ce6afa3

Browse files
committed
Merge branch 'main' into v2_json_support
2 parents 4cbf494 + 2de860e commit ce6afa3

File tree

5 files changed

+64
-13
lines changed

5 files changed

+64
-13
lines changed

clickhouse-jdbc/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,7 @@
302302
<include>com.clickhouse:clickhouse-http-client</include>
303303
<include>org.apache.httpcomponents.client5:httpclient5</include>
304304
<include>org.apache.httpcomponents.core5:httpcore5</include>
305+
<include>org.apache.httpcomponents.core5:httpcore5-h2</include>
305306
<include>org.lz4:lz4-pure-java</include>
306307
</includes>
307308
</artifactSet>

client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -531,6 +531,7 @@ private HttpEntity wrapEntity(HttpEntity httpEntity, int httpStatus, boolean isR
531531
case HttpStatus.SC_NOT_MODIFIED:
532532
case HttpStatus.SC_BAD_REQUEST:
533533
case HttpStatus.SC_INTERNAL_SERVER_ERROR:
534+
case HttpStatus.SC_NOT_FOUND:
534535
boolean useHttpCompression = MapUtils.getFlag(chConfiguration, "client.use_http_compression", false);
535536
return new LZ4Entity(httpEntity, useHttpCompression, serverCompression, clientCompression,
536537
MapUtils.getInt(chConfiguration, "compression.lz4.uncompressed_buffer_size"), isResponse);

client-v2/src/test/java/com/clickhouse/client/HttpTransportTests.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,16 @@ public void testServerErrorHandling(ClickHouseFormat format, boolean serverCompr
341341
"Unexpected error message: " + e.getMessage());
342342
}
343343

344+
querySettings.serverSetting("unknown_setting", "1");
345+
try (QueryResponse response = client.query("CREATE TABLE table_from_csv AS SELECT * FROM file('empty.csv')", querySettings)
346+
.get(1, TimeUnit.SECONDS)) {
347+
Assert.fail("Expected exception");
348+
} catch (ServerException e) {
349+
e.printStackTrace();
350+
Assert.assertEquals(e.getCode(), 115);
351+
Assert.assertTrue(e.getMessage().startsWith("Code: 115. DB::Exception: Setting unknown_setting is neither a builtin setting nor started with the prefix 'custom_' registered for user-defined settings. (UNKNOWN_SETTING)"),
352+
"Unexpected error message: " + e.getMessage());
353+
}
344354

345355
} catch (Exception e) {
346356
e.printStackTrace();

examples/jdbc/README.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,15 @@ To run simplified example:
1818
mvn exec:java -Dexec.mainClass="com.clickhouse.examples.jdbc.Basic"
1919
```
2020

21+
To run example with jdbc-all packaging (fat-jar):
22+
```shell
23+
mvn -Pfatjar exec:java -Dexec.mainClass="com.clickhouse.examples.jdbc.Basic"
24+
```
25+
26+
To run example with jdbc-shaded packaging:
27+
```shell
28+
mvn -Pshaded exec:java -Dexec.mainClass="com.clickhouse.examples.jdbc.Basic"
29+
```
30+
2131
Addition options can be passed to the application:
2232
- `-DchUrl` - ClickHouse JDBC URL. Default is `jdbc:clickhouse://localhost:8123/default`

examples/jdbc/pom.xml

Lines changed: 42 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -75,25 +75,54 @@
7575
<minJdk>1.8</minJdk>
7676
</properties>
7777

78+
<profiles>
79+
<profile>
80+
<id>http</id>
81+
<activation>
82+
<activeByDefault>true</activeByDefault>
83+
</activation>
84+
<dependencies>
85+
<dependency>
86+
<groupId>com.clickhouse</groupId>
87+
<artifactId>clickhouse-jdbc</artifactId>
88+
<version>${clickhouse-java.version}</version>
89+
<classifier>http</classifier>
90+
</dependency>
91+
</dependencies>
92+
</profile>
93+
94+
<profile>
95+
<id>shaded</id>
96+
<dependencies>
97+
<dependency>
98+
<groupId>com.clickhouse</groupId>
99+
<artifactId>clickhouse-jdbc</artifactId>
100+
<version>${clickhouse-java.version}</version>
101+
<classifier>shaded</classifier>
102+
</dependency>
103+
</dependencies>
104+
</profile>
105+
106+
<profile>
107+
<id>fatjar</id>
108+
<dependencies>
109+
<dependency>
110+
<groupId>com.clickhouse</groupId>
111+
<artifactId>clickhouse-jdbc</artifactId>
112+
<version>${clickhouse-java.version}</version>
113+
<classifier>all</classifier>
114+
</dependency>
115+
</dependencies>
116+
</profile>
117+
118+
</profiles>
119+
78120
<dependencies>
79-
<dependency>
80-
<groupId>com.clickhouse</groupId>
81-
<artifactId>clickhouse-jdbc</artifactId>
82-
<version>${clickhouse-java.version}</version>
83-
<classifier>http</classifier>
84-
</dependency>
85121
<dependency>
86122
<groupId>com.zaxxer</groupId>
87123
<artifactId>HikariCP</artifactId>
88124
<version>${hikaricp.version}</version>
89125
</dependency>
90-
91-
<!-- Recommended to communicate with ClickHouse server over http -->
92-
<dependency>
93-
<groupId>org.apache.httpcomponents.client5</groupId>
94-
<artifactId>httpclient5</artifactId>
95-
<version>${apache-httpclient.version}</version>
96-
</dependency>
97126
</dependencies>
98127

99128
<build>

0 commit comments

Comments
 (0)