Skip to content

Commit ceb3ac4

Browse files
committed
fix setting default password
1 parent 0d98bfb commit ceb3ac4

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

client-v2/src/main/java/com/clickhouse/client/api/ClientConfigProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public enum ClientConfigProperties {
2222

2323
USER("user", "default"),
2424

25-
PASSWORD("password", ""),
25+
PASSWORD("password"),
2626

2727
/**
2828
* Maximum number of active connection in internal connection pool.

client-v2/src/test/java/com/clickhouse/client/ClientTests.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,8 @@ public void testDisableNative() {
197197

198198
@Test(groups = {"integration"})
199199
public void testDefaultSettings() {
200-
try (Client client = new Client.Builder().setUsername("default").addEndpoint("http://localhost:8123").build()) {
200+
try (Client client = new Client.Builder().setUsername("default").setPassword("secret")
201+
.addEndpoint("http://localhost:8123").build()) {
201202
Map<String, String> config = client.getConfiguration();
202203
for (ClientConfigProperties p : ClientConfigProperties.values()) {
203204
if (p.getDefaultValue() != null) {
@@ -210,6 +211,7 @@ public void testDefaultSettings() {
210211

211212
try (Client client = new Client.Builder()
212213
.setUsername("default")
214+
.setPassword("secret")
213215
.addEndpoint("http://localhost:8123")
214216
.setDefaultDatabase("mydb")
215217
.setExecutionTimeout(10, MILLIS)
@@ -268,6 +270,7 @@ public void testDefaultSettings() {
268270
public void testWithOldDefaults() {
269271
try (Client client = new Client.Builder()
270272
.setUsername("default")
273+
.setPassword("seceret")
271274
.addEndpoint("http://localhost:8123")
272275
.setDefaultDatabase("default")
273276
.setExecutionTimeout(0, MILLIS)

0 commit comments

Comments
 (0)