Skip to content

Commit cf6d4cc

Browse files
committed
fixed jdbc url for cloud
1 parent 0814b5d commit cf6d4cc

File tree

2 files changed

+5
-62
lines changed

2 files changed

+5
-62
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ jobs:
196196
CLICKHOUSE_CLOUD_HOST: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT }}
197197
CLICKHOUSE_CLOUD_PASSWORD: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_PASSWORD_SMT }}
198198
run: |
199-
mvn --also-make --batch-mode --no-transfer-progress --projects clickhouse-http-client -DclickhouseVersion=${{ matrix.clickhouse }} verify
199+
mvn --also-make --batch-mode --no-transfer-progress --projects clickhouse-http-client,client-v2 -DclickhouseVersion=${{ matrix.clickhouse }} verify
200200
- name: Upload test results
201201
uses: actions/upload-artifact@v4
202202
if: failure()
@@ -217,7 +217,7 @@ jobs:
217217
project: ["clickhouse-http-client", "clickhouse-jdbc", "client-v2", "jdbc-v2"]
218218
fail-fast: false
219219
timeout-minutes: 15
220-
name: Java client (http) + CH ${{ matrix.clickhouse }}
220+
name: ${{ matrix.project }} + CH ${{ matrix.clickhouse }}
221221
steps:
222222
- name: Check out repository
223223
uses: actions/checkout@v4
@@ -265,7 +265,7 @@ jobs:
265265
uses: actions/upload-artifact@v4
266266
if: failure()
267267
with:
268-
name: result ${{ github.job }}
268+
name: result ${{ github.job }}_${{ matrix.project }}_${{ matrix.clickhouse }}
269269
path: |
270270
**/target/failsafe-reports
271271
**/target/surefire-reports
@@ -322,7 +322,7 @@ jobs:
322322
CLICKHOUSE_CLOUD_HOST: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT }}
323323
CLICKHOUSE_CLOUD_PASSWORD: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_PASSWORD_SMT }}
324324
run: |
325-
mvn --batch-mode --no-transfer-progress --projects clickhouse-jdbc -DclickhouseVersion=${{ matrix.clickhouse }} -Dprotocol=${{ matrix.protocol }} verify
325+
mvn --batch-mode --no-transfer-progress --projects clickhouse-jdbc,jdbc-v2 -DclickhouseVersion=${{ matrix.clickhouse }} -Dprotocol=${{ matrix.protocol }} verify
326326
- name: Upload test results
327327
uses: actions/upload-artifact@v4
328328
if: failure()
@@ -446,60 +446,3 @@ jobs:
446446
path: |
447447
**/target/failsafe-reports
448448
**/target/surefire-reports
449-
450-
test-client-v2:
451-
runs-on: ubuntu-latest
452-
needs: compile
453-
strategy:
454-
matrix:
455-
# most recent LTS releases as well as latest stable builds
456-
# https://github.com/ClickHouse/ClickHouse/pulls?q=is%3Aopen+is%3Apr+label%3Arelease
457-
clickhouse: ["24.3", "24.8", "latest"]
458-
fail-fast: false
459-
timeout-minutes: 15
460-
name: Client V2 + CH ${{ matrix.clickhouse }}
461-
steps:
462-
- name: Check out repository
463-
uses: actions/checkout@v4
464-
- name: Check out PR
465-
run: |
466-
git fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 \
467-
origin pull/${{ github.event.inputs.pr }}/merge:merged-pr && git checkout merged-pr
468-
if: github.event.inputs.pr != ''
469-
- name: Install JDK 17 and Maven
470-
uses: actions/setup-java@v4
471-
with:
472-
distribution: "temurin"
473-
java-version: |
474-
8
475-
17
476-
cache: "maven"
477-
- name: Setup Toolchain
478-
shell: bash
479-
run: |
480-
mkdir -p $HOME/.m2 \
481-
&& cat << EOF > $HOME/.m2/toolchains.xml
482-
<?xml version="1.0" encoding="UTF8"?>
483-
<toolchains>
484-
<toolchain>
485-
<type>jdk</type>
486-
<provides>
487-
<version>17</version>
488-
</provides>
489-
<configuration>
490-
<jdkHome>${{ env.JAVA_HOME }}</jdkHome>
491-
</configuration>
492-
</toolchain>
493-
</toolchains>
494-
EOF
495-
- name: Test Java client
496-
run: |
497-
mvn --also-make --batch-mode --no-transfer-progress --projects client-v2 -Dclient.tests.useNewImplementation=true -DclickhouseVersion=${{ matrix.clickhouse }} verify
498-
- name: Upload test results
499-
uses: actions/upload-artifact@v4
500-
if: failure()
501-
with:
502-
name: result ${{ github.job }}
503-
path: |
504-
**/target/failsafe-reports
505-
**/target/surefire-reports

jdbc-v2/src/test/java/com/clickhouse/jdbc/JdbcIntegrationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public String getEndpointString() {
2020
return getEndpointString(isCloud());
2121
}
2222
public String getEndpointString(boolean includeDbName) {
23-
return "jdbc:ch:" + (isCloud() ? "https" : "http") + "://" +
23+
return "jdbc:ch:" + (isCloud() ? "" : "http://") +
2424
ClickHouseServerForTest.getClickHouseAddress(ClickHouseProtocol.HTTP, false) + "/" + (includeDbName ? ClickHouseServerForTest.getDatabase() : "");
2525
}
2626

0 commit comments

Comments
 (0)