Code review comments

Author: Paultagoras

.github/workflows/analysis.yml

@@ -33,7 +33,7 @@ env:
 jobs:
   static:
     runs-on: ubuntu-latest
-    timeout-minutes: 45
+    timeout-minutes: 30
     name: Static code analysis
     steps:
       - name: Check out Git repository

.github/workflows/build.yml

@@ -179,7 +179,7 @@ jobs:
       matrix:
         # most recent LTS releases as well as latest stable builds
         # https://github.com/ClickHouse/ClickHouse/pulls?q=is%3Aopen+is%3Apr+label%3Arelease
-        clickhouse: ["22.8", "23.3", "23.7", "latest"]
+        clickhouse: ["23.8", "24.3", "24.6", "latest"]
       fail-fast: false
     timeout-minutes: 15
     name: Java client + CH ${{ matrix.clickhouse }}
@@ -298,7 +298,7 @@ jobs:
     needs: compile
     strategy:
       matrix:
-        clickhouse: ["22.8", "23.3", "23.7", "latest", "cloud"]
+        clickhouse: ["23.8", "24.3", "24.6", "latest", "cloud"]
         # here http, http_client and apache_http_client represent different value of http_connection_provider
         protocol: ["http", "http_client", "apache_http_client", "grpc"]
       fail-fast: false

clickhouse-client/src/test/java/com/clickhouse/client/ClickHouseNodeTest.java

@@ -410,7 +410,7 @@ public void testProbe() {
             }
             int port = p.getDefaultPort();
             if (isCloud()) {
-                port = 8433;
+                port = 8443;
             }
             ClickHouseNode node = getServer(ClickHouseProtocol.ANY, port);
             ClickHouseNode probedNode = node.probe();

clickhouse-client/src/test/java/com/clickhouse/client/ClickHouseServerForTest.java

@@ -387,6 +387,7 @@ public static boolean runQuery(String sql) {
                 Thread.sleep(15000);
             } catch (InterruptedException e) {
                 LOGGER.error("Failed to sleep", e);
+                throw new RuntimeException(e);
             }
         } while(retries++ < 10);
 

clickhouse-http-client/src/test/java/com/clickhouse/client/http/ClickHouseHttpClientTest.java

@@ -423,7 +423,7 @@ public void testLogComment() throws ClickHouseException {
                 try {
                     Thread.sleep(30000);
                 } catch (InterruptedException e) {
-                    // ignore
+                    throw new RuntimeException(e);
                 }
             }