fixed LZ4OutputStream

Author: chernser

client-v2/src/main/java/com/clickhouse/client/api/internal/ClickHouseLZ4OutputStream.java

@@ -9,9 +9,9 @@
 
 public class ClickHouseLZ4OutputStream extends OutputStream {
 
-    public static final int UNCOMPRESSED_BUFF_SIZE = 8192;
+    public static final int UNCOMPRESSED_BUFF_SIZE = 64 * 1024; // 64K is most optimal for LZ4 compression
 
-    private final ByteBuffer buffer;
+    private final ByteBuffer inBuffer;
 
     private final OutputStream out;
 
@@ -26,16 +26,27 @@ public class ClickHouseLZ4OutputStream extends OutputStream {
 
     public ClickHouseLZ4OutputStream(OutputStream out, LZ4Compressor compressor, int bufferSize) {
         super();
-        this.buffer = ByteBuffer.allocate(bufferSize);
+        this.inBuffer = ByteBuffer.allocate(bufferSize);
         this.out = out;
         this.compressor = compressor;
-        this.compressedBuffer = ByteBuffer.allocate(compressor.maxCompressedLength(buffer.capacity()) + HEADER_LEN);
+        this.compressedBuffer = ByteBuffer.allocate(compressor.maxCompressedLength(inBuffer.capacity()) + HEADER_LEN);
     }
 
     @Override
     public void write(int b) throws IOException {
-        tmpBuffer[0] = (byte) b;
-        write(tmpBuffer, 0, 1);
+        if (inBuffer.remaining() == 0) {
+            flush();
+        }
+        inBuffer.put((byte) b);
+    }
+
+    @Override
+    public void write(byte[] b) throws IOException {
+        if (b.length == 1) {
+            write(b[0]);
+        } else {
+            write(b, 0, b.length);
+        }
     }
 
     @Override
@@ -54,23 +65,23 @@ public void write( byte[] b, int off, int len) throws IOException {
 
         int writtenBytes = 0;
         do {
-            int remaining = Math.min(len - writtenBytes, buffer.remaining());
-            buffer.put(b, off + writtenBytes, remaining);
-            writtenBytes += remaining;
-            if (buffer.remaining() == 0) {
-                flush();
+            if (inBuffer.remaining() == 0) {
+                flush(); // flush will make inBuffer clear
             }
+            int remaining = Math.min(len - writtenBytes, inBuffer.remaining());
+            inBuffer.put(b, off + writtenBytes, remaining);
+            writtenBytes += remaining;
         } while (writtenBytes < len);
     }
 
     @Override
     public void flush() throws IOException {
-        if (buffer.position() > 0) {
+        if (inBuffer.position() > 0) {
             compressedBuffer.clear();
             compressedBuffer.put(16, ClickHouseLZ4InputStream.MAGIC);
-            int uncompressedLen = buffer.position();
-            buffer.flip();
-            int compressed = compressor.compress(buffer, 0, uncompressedLen, compressedBuffer, 25,
+            int uncompressedLen = inBuffer.position();
+            inBuffer.flip();
+            int compressed = compressor.compress(inBuffer, 0, uncompressedLen, compressedBuffer, 25,
                     compressedBuffer.remaining() - 25);
             int compressedSizeWithHeader = compressed + 9;
             ClickHouseLZ4InputStream.setInt32(compressedBuffer.array(), 17, compressedSizeWithHeader); // compressed size with header
@@ -80,7 +91,7 @@ public void flush() throws IOException {
             setInt64(compressedBuffer.array(), 8, hash[1]);
             compressedBuffer.flip();
             out.write(compressedBuffer.array(), 0, compressed + 25);
-            buffer.clear();
+            inBuffer.clear();
         }
     }
 

performance/src/test/com/clickhouse/benchmark/BenchmarkRunner.java

@@ -32,18 +32,18 @@ public static void main(String[] args) throws Exception {
         Options opt = new OptionsBuilder()
                 .include(QueryClient.class.getSimpleName())
                 .include(InsertClient.class.getSimpleName())
-//                .include(Components.class.getSimpleName())
+                .include(Components.class.getSimpleName())
                 .forks(1) // must be a fork. No fork only for debugging
                 .mode(Mode.SampleTime)
                 .timeUnit(TimeUnit.MILLISECONDS)
                 .threads(1)
                 .addProfiler(GCProfiler.class)
                 .addProfiler(MemPoolProfiler.class)
-                .warmupIterations(3)
+                .warmupIterations(0)
                 .warmupTime(TimeValue.seconds(10))
-                .measurementIterations(10)
+                .measurementIterations(5)
                 .jvmArgs("-Xms8g", "-Xmx8g")
-                .measurementTime(TimeValue.seconds(isCloud() ? 30 : 10))
+                .measurementTime(TimeValue.seconds(30))
                 .resultFormat(ResultFormatType.JSON)
                 .output(String.format("jmh-results-%s-%s.out", isCloud() ? "cloud" : "local", System.currentTimeMillis()))
                 .result(String.format("jmh-results-%s-%s.json", isCloud() ? "cloud" : "local", System.currentTimeMillis()))

performance/src/test/com/clickhouse/benchmark/clients/Components.java

@@ -25,11 +25,12 @@
 public class Components extends BenchmarkBase {
     private static final Logger LOGGER = LoggerFactory.getLogger(Components.class);
 
+    static final int COMPRESS_BUFFER_SIZE = 64 * 1024; // 64K
     @Benchmark
     public void CompressingOutputStreamV1(DataState dataState) {
         DataSet dataSet = dataState.dataSet;
         try (ByteArrayOutputStream baos = new ByteArrayOutputStream(); ClickHouseOutputStream out =
-                new Lz4OutputStream(baos, 8196, null)) {
+                new Lz4OutputStream(baos, COMPRESS_BUFFER_SIZE, null)) {
             for (byte[] bytes : dataSet.getBytesList(dataSet.getFormat())) {
                 out.write(bytes);
             }
@@ -45,7 +46,7 @@ public void CompressingOutputStreamV2(DataState dataState) {
         DataSet dataSet = dataState.dataSet;
         try (ByteArrayOutputStream baos = new ByteArrayOutputStream();
              ClickHouseLZ4OutputStream out = new ClickHouseLZ4OutputStream(baos,
-                factory.fastCompressor(),  8196)) {
+                factory.fastCompressor(),  COMPRESS_BUFFER_SIZE)) {
             for (byte[] bytes : dataSet.getBytesList(dataSet.getFormat())) {
                 out.write(bytes);
             }
@@ -83,7 +84,7 @@ public void close() {
             }
         };
     }
-    @Benchmark
+//    @Benchmark
     public void SerializerOutputStreamV1(DataState dataState) {
         OutputStream empty = createEmptyOutputStream();
         try {
@@ -101,7 +102,7 @@ public void SerializerOutputStreamV1(DataState dataState) {
         }
     }
 
-    @Benchmark
+//    @Benchmark
     public void SerializerOutputStreamV2(DataState dataState) {
         OutputStream empty = createEmptyOutputStream();
         try {