fixed reading boolean in detached result set (database metadata). fixes 2586

Author: chernser

jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/JdbcUtils.java

@@ -232,7 +232,8 @@ public static Object convert(Object value, Class<?> type, ClickHouseColumn colum
             } else if (type == String.class) {
                 return value.toString();
             } else if (type == Boolean.class || type == boolean.class) {
-                return Boolean.parseBoolean(value.toString());
+                String str = value.toString();
+                return !("false".equalsIgnoreCase(str) || "0".equalsIgnoreCase(str));
             } else if (type == Byte.class || type == byte.class) {
                 return Byte.parseByte(value.toString());
             } else if (type == Short.class || type == short.class) {

jdbc-v2/src/test/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataTest.java

@@ -37,7 +37,7 @@ public void testGetColumns() throws Exception {
             final String tableName = "get_columns_metadata_test";
             try (Statement stmt = conn.createStatement()) {
                 stmt.executeUpdate("" +
-                        "CREATE TABLE " + tableName + " (id Int32, name String, v1 Nullable(Int8)) " +
+                        "CREATE TABLE " + tableName + " (id Int32, name String NOT NULL, v1 Nullable(Int8)) " +
                         "ENGINE MergeTree ORDER BY ()");
             }
 
@@ -109,6 +109,7 @@ public void testGetColumns() throws Exception {
                 assertEquals(rs.getInt("DATA_TYPE"), Types.INTEGER);
                 assertEquals(rs.getObject("DATA_TYPE"), Types.INTEGER);
                 assertEquals(rs.getString("TYPE_NAME"), "Int32");
+                assertFalse(rs.getBoolean("NULLABLE"));
 
                 assertTrue(rs.next());
                 assertEquals(rs.getString("TABLE_SCHEM"), getDatabase());
@@ -117,6 +118,7 @@ public void testGetColumns() throws Exception {
                 assertEquals(rs.getInt("DATA_TYPE"), Types.VARCHAR);
                 assertEquals(rs.getObject("DATA_TYPE"), Types.VARCHAR);
                 assertEquals(rs.getString("TYPE_NAME"), "String");
+                assertFalse(rs.getBoolean("NULLABLE"));
 
                 assertTrue(rs.next());
                 assertEquals(rs.getString("TABLE_SCHEM"), getDatabase());
@@ -125,6 +127,7 @@ public void testGetColumns() throws Exception {
                 assertEquals(rs.getInt("DATA_TYPE"), Types.TINYINT);
                 assertEquals(rs.getObject("DATA_TYPE"), Types.TINYINT);
                 assertEquals(rs.getString("TYPE_NAME"), "Nullable(Int8)");
+                assertTrue(rs.getBoolean("NULLABLE"));
             }
         }
     }