Skip to content

Commit e969608

Browse files
committed
fixed some tests
1 parent 48a0b09 commit e969608

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ jobs:
268268
needs: compile
269269
strategy:
270270
matrix:
271-
clickhouse: ["23.8", "24.3", "24.6", "latest"]
271+
clickhouse: ["23.8", "24.3", "24.8", "latest"]
272272
# here http, http_client and apache_http_client represent different value of http_connection_provider
273273
# protocol: ["http", "http_client", "apache_http_client"]
274274
protocol: ["apache_http_client"]
@@ -321,7 +321,7 @@ jobs:
321321
uses: actions/upload-artifact@v4
322322
if: failure()
323323
with:
324-
name: result ${{ github.job }}
324+
name: result ${{ github.job }}_${{ matrix.project }}_${{ matrix.clickhouse }}
325325
path: |
326326
**/target/failsafe-reports
327327
**/target/surefire-reports

client-v2/src/test/java/com/clickhouse/client/datatypes/DataTypeTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -608,7 +608,7 @@ public static String tableDefinition(String table, String... columns) {
608608
return sb.toString();
609609
}
610610

611-
public boolean isVersionMatch(String versionExpression) {
611+
private boolean isVersionMatch(String versionExpression) {
612612
List<GenericRecord> serverVersion = client.queryAll("SELECT version()");
613613
return ClickHouseVersion.of(serverVersion.get(0).getString(1)).check(versionExpression);
614614
}

client-v2/src/test/java/com/clickhouse/client/insert/InsertTests.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -642,6 +642,9 @@ public static Object[][] testAppCompressionDataProvider() {
642642

643643
@Test(groups = { "integration" }, enabled = true)
644644
public void testPOJOWithDynamicType() throws Exception {
645+
if (isVersionMatch("(,24.8]")) {
646+
return;
647+
}
645648
final String tableName = "pojo_dynamic_type_test";
646649
final String createSQL = PojoWithDynamic.getTableDef(tableName);
647650

@@ -685,4 +688,9 @@ protected void initTable(String tableName, String createTableSQL, CommandSetting
685688
client.execute("DROP TABLE IF EXISTS " + tableName, settings).get(EXECUTE_CMD_TIMEOUT, TimeUnit.SECONDS);
686689
client.execute(createTableSQL, settings).get(EXECUTE_CMD_TIMEOUT, TimeUnit.SECONDS);
687690
}
691+
692+
private boolean isVersionMatch(String versionExpression) {
693+
List<GenericRecord> serverVersion = client.queryAll("SELECT version()");
694+
return ClickHouseVersion.of(serverVersion.get(0).getString(1)).check(versionExpression);
695+
}
688696
}

0 commit comments

Comments
 (0)