Skip to content

Commit f9addcd

Browse files
committed
fixed issues with metrics in tests
1 parent 5da6ce6 commit f9addcd

File tree

6 files changed

+15
-5
lines changed

6 files changed

+15
-5
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ jobs:
249249
run: mvn --also-make --batch-mode --no-transfer-progress -DskipTests install
250250
- name: Generate JWT
251251
env:
252-
JWT_K_PEM: ${{ secrets.JWT_K_PEM }}
252+
JWT_K_PEM: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_JWT_PRIVATE_KEY }}
253253
run: |
254254
npm install jsonwebtoken &&
255255
echo "CLIENT_JWT=$(node jwt-gen.js)" >> "$GITHUB_ENV"

client-v2/src/test/java/com/clickhouse/client/insert/InsertTests.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,8 @@ protected Client.Builder newClient() {
8989
.compressClientRequest(useClientCompression)
9090
.useHttpCompression(useHttpCompression)
9191
.setDefaultDatabase(ClickHouseServerForTest.getDatabase())
92-
.serverSetting(ServerSettings.WAIT_ASYNC_INSERT, "1")
92+
.serverSetting(ServerSettings.ASYNC_INSERT, "0")
93+
.serverSetting(ServerSettings.WAIT_END_OF_QUERY, "1")
9394
.useNewImplementation(System.getProperty("client.tests.useNewImplementation", "true").equals("true"));
9495
}
9596

@@ -127,6 +128,10 @@ public void insertSimplePOJOs() throws Exception {
127128

128129
@Test(groups = { "integration" }, enabled = true)
129130
public void insertPOJOWithJSON() throws Exception {
131+
if (isCloud()) {
132+
return; // not working because of Code: 452. DB::Exception: Setting allow_experimental_json_type should not be changed. (SETTING_CONSTRAINT_VIOLATION)
133+
// but without this setting it doesn't let to create a table
134+
}
130135
List<GenericRecord> serverVersion = client.queryAll("SELECT version()");
131136
if (ClickHouseVersion.of(serverVersion.get(0).getString(1)).check("(,24.8]")) {
132137
System.out.println("Test is skipped: feature is supported since 24.8");

client-v2/src/test/java/com/clickhouse/client/query/QueryTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1931,6 +1931,7 @@ protected Client.Builder newClient() {
19311931
.allowBinaryReaderToReuseBuffers(usePreallocatedBuffers)
19321932
.setDefaultDatabase(ClickHouseServerForTest.getDatabase())
19331933
.serverSetting(ServerSettings.WAIT_ASYNC_INSERT, "1")
1934+
.serverSetting(ServerSettings.ASYNC_INSERT, "0")
19341935
.useNewImplementation(System.getProperty("client.tests.useNewImplementation", "true").equals("true"));
19351936
}
19361937

jdbc-v2/src/main/java/com/clickhouse/jdbc/ConnectionImpl.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.clickhouse.client.api.Client;
44
import com.clickhouse.client.api.ClientConfigProperties;
5+
import com.clickhouse.client.api.internal.ServerSettings;
56
import com.clickhouse.client.api.query.GenericRecord;
67
import com.clickhouse.client.api.query.QuerySettings;
78
import com.clickhouse.data.ClickHouseDataType;
@@ -75,7 +76,9 @@ public ConnectionImpl(String url, Properties info) throws SQLException {
7576
.setClientName(clientName)
7677
.build();
7778
this.schema = client.getDefaultDatabase();
78-
this.defaultQuerySettings = new QuerySettings();
79+
this.defaultQuerySettings = new QuerySettings()
80+
.serverSetting(ServerSettings.ASYNC_INSERT, "0")
81+
.serverSetting(ServerSettings.WAIT_END_OF_QUERY, "1");
7982

8083
this.metadata = new com.clickhouse.jdbc.metadata.DatabaseMetaData(this, false, url);
8184
}

jdbc-v2/src/main/java/com/clickhouse/jdbc/StatementImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.clickhouse.jdbc;
22

3+
import com.clickhouse.client.api.ClientConfigProperties;
34
import com.clickhouse.client.api.data_formats.ClickHouseBinaryFormatReader;
45
import com.clickhouse.client.api.internal.ServerSettings;
56
import com.clickhouse.client.api.metrics.OperationMetrics;
@@ -191,7 +192,7 @@ public int executeUpdate(String sql, QuerySettings settings) throws SQLException
191192
}
192193

193194
QuerySettings mergedSettings = QuerySettings.merge(connection.getDefaultQuerySettings(), settings);
194-
mergedSettings.serverSetting(ServerSettings.WAIT_END_OF_QUERY, "1");
195+
195196
lastSql = parseJdbcEscapeSyntax(sql);
196197
int updateCount = 0;
197198
try (QueryResponse response = queryTimeout == 0 ? connection.client.query(lastSql, mergedSettings).get()

jdbc-v2/src/test/java/com/clickhouse/jdbc/JdbcIntegrationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public Connection getJdbcConnection(Properties properties) throws SQLException {
3434
Properties info = new Properties();
3535
info.setProperty("user", "default");
3636
info.setProperty("password", ClickHouseServerForTest.getPassword());
37-
info.setProperty(ServerSettings.WAIT_ASYNC_INSERT, "1");
37+
3838
if (properties != null) {
3939
info.putAll(properties);
4040
}

0 commit comments

Comments
 (0)