fixed selecting default user when password is empty or null

Author: chernser

clickhouse-http-client/src/main/java/com/clickhouse/client/http/ClickHouseHttpConnection.java

@@ -243,9 +243,10 @@ protected static Map<String, String> createDefaultHeaders(ClickHouseConfig confi
             if (config.isSsl() && !ClickHouseChecker.isNullOrEmpty(config.getSslCert())) {
                 map.put("x-clickhouse-user", credentials.getUserName());
                 map.put("x-clickhouse-ssl-certificate-auth", "on");
-            } else if (!ClickHouseChecker.isNullOrEmpty(credentials.getPassword())) {
+            } else {
+                String password = credentials.getPassword() == null ? "" : credentials.getPassword();
                 map.put(HttpHeaders.AUTHORIZATION, "Basic " + Base64.getEncoder()
-                        .encodeToString((credentials.getUserName() + ":" + credentials.getPassword()).getBytes(StandardCharsets.UTF_8)));
+                        .encodeToString((credentials.getUserName() + ":" + password).getBytes(StandardCharsets.UTF_8)));
             }
         }
 

clickhouse-jdbc/src/test/java/com/clickhouse/jdbc/AccessManagementTest.java

@@ -195,9 +195,9 @@ public void testPasswordAuthentication(String identifyWith, String identifyBy) t
 
         try (Connection connection = dataSource.getConnection("some_user", identifyBy)) {
             Statement st = connection.createStatement();
-            ResultSet rs = st.executeQuery("SELECT 1");
+            ResultSet rs = st.executeQuery("SELECT user() AS user_name");
             Assert.assertTrue(rs.next());
-            Assert.assertEquals(rs.getInt(1), 1);
+            Assert.assertEquals(rs.getString(1), "some_user");
         } catch (Exception e) {
             Assert.fail("Failed to authenticate", e);
         }
@@ -207,6 +207,7 @@ public void testPasswordAuthentication(String identifyWith, String identifyBy) t
     private static Object[][] passwordAuthMethods() {
         return new Object[][] {
                 { "plaintext_password", "password" },
+                { "plaintext_password", "" },
                 { "plaintext_password", "S3Cr=?t"},
                 { "plaintext_password", "123§" },
                 { "sha256_password", "password" },

client-v2/src/test/java/com/clickhouse/client/HttpTransportTests.java

@@ -517,9 +517,7 @@ public void testPasswordAuthentication(String identifyWith, String identifyBy) t
                 .setPassword(identifyBy)
                 .build()) {
 
-            try (QueryResponse resp = client.query("SELECT 1").get()) {
-                Assert.assertEquals(resp.getReadRows(), 1);
-            }
+            Assert.assertEquals(client.queryAll("SELECT user()").get(0).getString(1), "some_user");
         } catch (Exception e) {
             Assert.fail("Failed to authenticate", e);
         }
@@ -529,6 +527,7 @@ public void testPasswordAuthentication(String identifyWith, String identifyBy) t
     public static Object[][] testPasswordAuthenticationProvider() {
         return new Object[][] {
                 { "plaintext_password", "password" },
+                { "plaintext_password", "" },
                 { "plaintext_password", "S3Cr=?t"},
                 { "plaintext_password", "123§" },
                 { "sha256_password", "password" },