feat(ci): upgrade eslint to v9 (#457)

Author: eryue0220

.build/build_and_prepare.ts

@@ -1,7 +1,8 @@
 import { execSync } from 'child_process'
 import fs from 'fs'
 import * as process from 'process'
-;(() => {
+
+void (async () => {
   const [pkg] = process.argv.slice(2)
   if (!pkg) {
     console.error(`Expected package name as an argument`)
@@ -22,14 +23,19 @@ import * as process from 'process'
 
   fs.copyFileSync(`./packages/${packageName}/package.json`, './package.json')
 
-  const packageJson = require('../package.json')
-  const version = require(`../packages/${packageName}/src/version.ts`).default
+  const packageJson = (await import('../package.json').then(
+    (m) => m.default,
+  )) as any
+  const version = (
+    await import(`../packages/${packageName}/src/version` + '.ts')
+  ).default
   console.log(`Current ${packageName} package version is: ${version}`)
   packageJson.version = version
 
-  if (packageJson['dependencies']['@clickhouse/client-common']) {
-    const commonVersion =
-      require(`../packages/client-common/src/version.ts`).default
+  if (packageJson.dependencies['@clickhouse/client-common']) {
+    const commonVersion = (
+      await import('../packages/client-common/src/version' + '.ts')
+    ).default
     console.log(`Updating client-common dependency to ${commonVersion}`)
     packageJson['dependencies']['@clickhouse/client-common'] = commonVersion
   }
@@ -48,7 +54,7 @@ import * as process from 'process'
     fs.writeFileSync(
       './package.json',
       JSON.stringify(packageJson, null, 2) + '\n',
-      'utf-8'
+      'utf-8',
     )
   } catch (err) {
     console.error(err)

.eslintignore

@@ -0,0 +1,84 @@
+import js from '@eslint/js'
+import { defineConfig } from 'eslint/config'
+import pluginPrettier from 'eslint-plugin-prettier'
+import pluginExpectType from 'eslint-plugin-expect-type/configs/recommended'
+import globals from 'globals'
+import tseslint from 'typescript-eslint'
+
+export default defineConfig(
+  // Base ESLint recommended rules
+  js.configs.recommended,
+  // TypeScript-ESLint recommended rules with type checking
+  ...tseslint.configs.strict,
+  ...tseslint.configs.stylistic,
+  // Enable type-aware linting for TypeScript files only
+  {
+    files: ['**/*.ts'],
+    languageOptions: {
+      parserOptions: {
+        project: './tsconfig.all.json',
+      },
+    },
+  },
+  // Project-wide rules and plugins
+  {
+    plugins: {
+      prettier: pluginPrettier,
+      'expect-type': pluginExpectType,
+    },
+    rules: {
+      'prettier/prettier': 'error',
+      '@typescript-eslint/no-floating-promises': 'error',
+      eqeqeq: 'error',
+      'no-console': 'error',
+      // Keep some rules relaxed until addressed in dedicated PRs
+      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/consistent-type-imports': 'warn',
+      '@typescript-eslint/array-type': 'off',
+    },
+  },
+  // Test files overrides
+  {
+    files: ['./**/__tests__/**/*.ts'],
+    rules: {
+      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/no-non-null-assertion': 'off',
+      '@typescript-eslint/ban-ts-comment': 'off',
+      'no-constant-condition': 'off',
+      'no-console': 'off',
+    },
+  },
+  // Examples and benchmarks overrides
+  {
+    files: [
+      './**/examples/**/*.ts',
+      './**/benchmarks/**/*.ts',
+      '.build/*.ts',
+      '.scripts/*.ts',
+    ],
+    rules: {
+      'no-console': 'off',
+    },
+  },
+  // Root-level config files (ESM in Node)
+  {
+    files: ['*.mjs', '**/*.mjs'],
+    languageOptions: {
+      sourceType: 'module',
+      ecmaVersion: 'latest',
+      globals: globals.node,
+      parserOptions: {
+        projectService: false,
+      },
+    },
+    rules: {
+      '@typescript-eslint/no-floating-promises': 'off',
+      '@typescript-eslint/consistent-type-imports': 'off',
+      'no-console': 'off',
+    },
+  },
+  // Ignore build artifacts and externals
+  {
+    ignores: ['out', 'dist', 'node_modules', 'webpack'],
+  },
+)

.eslintrc.json

@@ -37,7 +37,10 @@ void (async () => {
     `,
   })
 
-  type Row = { id: number; name: string }
+  interface Row {
+    id: number
+    name: string
+  }
 
   // Assume we have an event listener in our application that periodically receives incoming data,
   // that we would like to have inserted into ClickHouse.

eslint.config.mjs

@@ -1,7 +1,7 @@
 import type { ClickHouseSettings } from '@clickhouse/client'
 import { createClient } from '@clickhouse/client' // or '@clickhouse/client-web'
 
-type Data = {
+interface Data {
   id: string
   timestamp: number
   email: string

examples/async_insert_without_waiting.ts

@@ -212,7 +212,7 @@ async function checkQueryExists(
   return result.length > 0 && result[0].exists !== 0
 }
 
-type QueryLogInfo = {
+interface QueryLogInfo {
   type:
     | 'QueryStart'
     | 'QueryFinish'

examples/insert_values_and_functions.ts

@@ -1,6 +1,8 @@
 import { createClient } from '@clickhouse/client' // or '@clickhouse/client-web'
 
-type Data = { number: string }
+interface Data {
+  number: string
+}
 
 void (async () => {
   const client = createClient()

examples/long_running_queries_timeouts.ts

@@ -1,8 +1,8 @@
-const webpackConfig = require('./webpack.dev.js')
+import webpackConfig from './webpack.dev.mjs'
 
 const TEST_TIMEOUT_MS = 400_000
 
-module.exports = function (config) {
+export default function (config) {
   config.set({
     // base path that will be used to resolve all patterns (e.g. files, exclude)
     basePath: '',

examples/select_json_each_row.ts

@@ -1,8 +1,8 @@
-const webpackConfig = require('./webpack.dev.js')
+import webpackConfig from './webpack.dev.mjs'
 
 const TEST_TIMEOUT_MS = 400_000
 
-module.exports = function (config) {
+export default function (config) {
   config.set({
     // base path that will be used to resolve all patterns (e.g. files, exclude)
     basePath: '',
@@ -29,10 +29,7 @@ module.exports = function (config) {
         'sourcemap',
       ],
       'packages/client-common/__tests__/utils/*.ts': ['webpack', 'sourcemap'],
-      'packages/client-web/__tests__/unit/*.test.ts': [
-        'webpack',
-        'sourcemap',
-      ],
+      'packages/client-web/__tests__/unit/*.test.ts': ['webpack', 'sourcemap'],
       'packages/client-web/__tests__/integration/*.ts': [
         'webpack',
         'sourcemap',