Skip to content

Conversation

@andreygmc
Copy link

@andreygmc andreygmc commented Nov 12, 2025

Summary

Added missing http settings:
"compress", "decompress", "quota_key", "buffer_size"

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2025

CLA assistant check
All committers have signed the CLA.

@slvrtrn
Copy link
Contributor

slvrtrn commented Nov 12, 2025

Added missing http settings:
"compress", "decompress", "user", "password", "quota_key", "query_id", "buffer_size", "wait_end_of_query", "session_id", "session_timeout", "session_check"

Why do we need user, password, query_id, session_id in the settings? Those are first-class config options already.

wait_end_of_query, session_timeout, session_check are already defined.

@andreygmc
Copy link
Author

Thanks. I have removed these options. And what about compress and decompress? Are they already defined in CompressionSettings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants