feat: add Client::{get_option, set_option}

Author: abonander

src/insert.rs

@@ -129,7 +129,7 @@ impl<T> Insert<T> {
     /// If called after the request is started, e.g., after [`Insert::write`].
     #[track_caller]
     pub fn with_option(mut self, name: impl Into<String>, value: impl Into<String>) -> Self {
-        self.insert.expect_client_mut().add_option(name, value);
+        self.insert.expect_client_mut().set_option(name, value);
         self
     }
 

src/insert_formatted.rs

@@ -195,7 +195,7 @@ impl InsertFormatted {
     /// If called after the request is started, e.g., after [`InsertFormatted::send`].
     #[track_caller]
     pub fn with_option(mut self, name: impl Into<String>, value: impl Into<String>) -> Self {
-        self.state.expect_client_mut().add_option(name, value);
+        self.state.expect_client_mut().set_option(name, value);
         self
     }
 

src/inserter.rs

@@ -213,7 +213,7 @@ where
     /// If you have already begun writing data, you may call [`Inserter::force_commit`]
     /// to end the current `INSERT` so this takes effect on the next call to [`Inserter::write`].
     pub fn with_option(mut self, name: impl Into<String>, value: impl Into<String>) -> Self {
-        self.client.add_option(name, value);
+        self.client.set_option(name, value);
         self
     }
 

src/lib.rs

@@ -383,6 +383,22 @@ impl Client {
         self
     }
 
+    /// Set an option on this instance of [`Client`].
+    ///
+    /// Returns the previous value for the option, if one was set.
+    pub fn set_option(
+        &mut self,
+        name: impl Into<String>,
+        value: impl Into<String>,
+    ) -> Option<String> {
+        self.options.insert(name.into(), value.into())
+    }
+
+    /// Get an option that was previously set on this `Client`.
+    pub fn get_option(&mut self, name: impl AsRef<str>) -> Option<&str> {
+        self.options.get(name.as_ref()).map(String::as_str)
+    }
+
     /// Starts a new INSERT statement.
     ///
     /// # Validation
@@ -503,12 +519,6 @@ impl Client {
         self.validation
     }
 
-    /// Used internally to modify the options map of an _already cloned_
-    /// [`Client`] instance.
-    pub(crate) fn add_option(&mut self, name: impl Into<String>, value: impl Into<String>) {
-        self.options.insert(name.into(), value.into());
-    }
-
     pub(crate) fn set_roles(&mut self, roles: impl IntoIterator<Item = impl Into<String>>) {
         self.clear_roles();
         self.roles.extend(roles.into_iter().map(Into::into));
@@ -823,4 +833,16 @@ mod client_tests {
         let client = client.with_option("async_insert", "1");
         assert_ne!(client.options, client_clone.options,);
     }
+
+    #[test]
+    fn it_gets_options() {
+        let mut client = Client::default();
+
+        client.set_option("foo", "foo");
+        client.set_option("bar", "bar");
+
+        assert_eq!(client.get_option("foo"), Some("foo"));
+        assert_eq!(client.get_option("bar"), Some("bar"));
+        assert_eq!(client.get_option("baz"), None);
+    }
 }

src/query.rs

@@ -236,7 +236,7 @@ impl Query {
 
     /// Similar to [`Client::with_option`], but for this particular query only.
     pub fn with_option(mut self, name: impl Into<String>, value: impl Into<String>) -> Self {
-        self.client.add_option(name, value);
+        self.client.set_option(name, value);
         self
     }