Skip to content

Commit 0e5ea14

Browse files
committed
Fix exception message & extract retry to const.
1 parent c94beb3 commit 0e5ea14

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

flink-connector-clickhouse-1.17/src/main/java/org/apache/flink/connector/clickhouse/sink/ClickHouseAsyncSinkSerializer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ protected ClickHousePayload deserializeRequestFromStream(long requestSize, DataI
4444
throw new IOException("Unsupported version " + version);
4545
}
4646
} else {
47-
throw new IOException("request size < 0");
47+
throw new IOException("Request size: " + requestSize);
4848
}
4949
}
5050

flink-connector-clickhouse-1.17/src/test/java/org/apache/flink/connector/clickhouse/sink/ClickHouseSinkTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ public class ClickHouseSinkTests extends FlinkClusterTests {
4545
static final long MAX_RECORD_SIZE_IN_BYTES = 1000;
4646

4747
static final int STREAM_PARALLELISM = 5;
48+
static final int NUMBER_OF_RETRIES = 10;
4849

4950
private String createSimplePOJOTableSQL(String database, String tableName, int parts_to_throw_insert) {
5051
String createTable = createSimplePOJOTableSQL(database, tableName);
@@ -511,7 +512,7 @@ void SimplePOJODataTooManyPartsTest() throws Exception {
511512
env.setParallelism(STREAM_PARALLELISM);
512513

513514
ClickHouseClientConfig clickHouseClientConfig = new ClickHouseClientConfig(getServerURL(), getUsername(), getPassword(), getDatabase(), tableName);
514-
clickHouseClientConfig.setNumberOfRetries(10);
515+
clickHouseClientConfig.setNumberOfRetries(NUMBER_OF_RETRIES);
515516
clickHouseClientConfig.setSupportDefault(simpleTableSchema.hasDefaults());
516517

517518
ElementConverter<SimplePOJO, ClickHousePayload> convertorCovid = new ClickHouseConvertor<>(SimplePOJO.class, simplePOJOConvertor);

flink-connector-clickhouse-2.0.0/src/main/java/org/apache/flink/connector/clickhouse/sink/ClickHouseAsyncSinkSerializer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ protected ClickHousePayload deserializeRequestFromStream(long requestSize, DataI
4444
throw new IOException("Unsupported version " + version);
4545
}
4646
} else {
47-
throw new IOException("request size < 0");
47+
throw new IOException("Request size: " + requestSize);
4848
}
4949
}
5050

flink-connector-clickhouse-2.0.0/src/test/java/org/apache/flink/connector/clickhouse/sink/ClickHouseSinkTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ public class ClickHouseSinkTests extends FlinkClusterTests {
4545
static final long MAX_RECORD_SIZE_IN_BYTES = 1000;
4646

4747
static final int STREAM_PARALLELISM = 5;
48+
static final int NUMBER_OF_RETRIES = 10;
4849

4950
private String createSimplePOJOTableSQL(String database, String tableName, int parts_to_throw_insert) {
5051
String createTable = createSimplePOJOTableSQL(database, tableName);
@@ -508,7 +509,7 @@ void SimplePOJODataTooManyPartsTest() throws Exception {
508509
env.setParallelism(STREAM_PARALLELISM);
509510

510511
ClickHouseClientConfig clickHouseClientConfig = new ClickHouseClientConfig(getServerURL(), getUsername(), getPassword(), getDatabase(), tableName);
511-
clickHouseClientConfig.setNumberOfRetries(10);
512+
clickHouseClientConfig.setNumberOfRetries(NUMBER_OF_RETRIES);
512513
clickHouseClientConfig.setSupportDefault(simpleTableSchema.hasDefaults());
513514

514515
ElementConverter<SimplePOJO, ClickHousePayload> convertorCovid = new ClickHouseConvertor<>(SimplePOJO.class, simplePOJOConvertor);

0 commit comments

Comments
 (0)