Skip to content

Commit bea0ec6

Browse files
committed
Address comments
1 parent a77846e commit bea0ec6

File tree

5 files changed

+6
-3
lines changed

5 files changed

+6
-3
lines changed

flink-connector-clickhouse-base/src/main/java/org/apache/flink/connector/clickhouse/convertor/ClickHouseConvertor.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
public class ClickHouseConvertor<InputT> implements ElementConverter<InputT, ClickHousePayload> {
1414
private static final Logger LOG = LoggerFactory.getLogger(ClickHouseConvertor.class);
15+
private static final long serialVersionUID = 1L;
1516

1617
POJOConvertor<InputT> pojoConvertor = null;
1718
enum Types {

flink-connector-clickhouse-base/src/main/java/org/apache/flink/connector/clickhouse/exception/RetriableException.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package org.apache.flink.connector.clickhouse.exception;
22

33
public class RetriableException extends FlinkWriteException {
4+
private static final long serialVersionUID = 1L;
5+
46
public RetriableException(String message) {
57
super(message);
68
}

flink-connector-clickhouse-base/src/main/java/org/apache/flink/connector/clickhouse/sink/ClickHouseAsyncSink.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import java.io.IOException;
1717
import java.util.Collection;
1818
import java.util.Collections;
19+
import java.util.Objects;
1920

2021
public class ClickHouseAsyncSink<InputT> extends AsyncSinkBase<InputT, ClickHousePayload> {
2122
private static final Logger LOG = LoggerFactory.getLogger(ClickHouseAsyncSink.class);
@@ -41,7 +42,7 @@ public ClickHouseAsyncSink(
4142
maxTimeInBufferMS,
4243
maxRecordSizeInByte);
4344

44-
this.clickHouseClientConfig = clickHouseClientConfig;
45+
this.clickHouseClientConfig = Objects.requireNonNull(clickHouseClientConfig, "ClickHouse config cannot be null");;
4546
}
4647

4748
public void setClickHouseFormat(ClickHouseFormat clickHouseFormat) {

flink-connector-clickhouse-base/src/main/java/org/apache/flink/connector/clickhouse/sink/ClickHouseClientConfig.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
public class ClickHouseClientConfig implements Serializable {
1111
private static final Logger LOG = LoggerFactory.getLogger(ClickHouseClientConfig.class);
12+
private static final long serialVersionUID = 1L;
1213

1314
private final String url;
1415
private final String username;

flink-connector-clickhouse-base/src/test/java/org/apache/flink/connector/clickhouse/sink/ClickHouseSinkTests.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,8 +226,6 @@ void SimplePOJODataTest() throws Exception {
226226
clickHouseClientConfig
227227
);
228228

229-
simplePOJOSink.setClickHouseFormat(ClickHouseFormat.RowBinary);
230-
231229
List<SimplePOJO> simplePOJOList = new ArrayList<>();
232230
for (int i = 0; i < EXPECTED_ROWS; i++) {
233231
simplePOJOList.add(new SimplePOJO(i));

0 commit comments

Comments
 (0)