core_banned_functions: use internal version of grpc_channel_destroy() inside C-core (#32495)

Author: markdroth

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc

@@ -1531,7 +1531,7 @@ void GrpcLb::ShutdownLocked() {
       GPR_ASSERT(child_channelz_node != nullptr);
       parent_channelz_node_->RemoveChildChannel(child_channelz_node->uuid());
     }
-    grpc_channel_destroy(lb_channel_);
+    grpc_channel_destroy_internal(lb_channel_);
     lb_channel_ = nullptr;
   }
 }

src/core/ext/filters/client_channel/lb_policy/rls/rls.cc

@@ -1631,7 +1631,7 @@ void RlsLb::RlsChannel::Orphan() {
       client_channel->RemoveConnectivityWatcher(watcher_);
       watcher_ = nullptr;
     }
-    grpc_channel_destroy(channel_);
+    grpc_channel_destroy_internal(channel_);
   }
   Unref(DEBUG_LOCATION, "Orphan");
 }

src/core/ext/xds/xds_transport_grpc.cc

@@ -291,7 +291,7 @@ GrpcXdsTransportFactory::GrpcXdsTransport::GrpcXdsTransport(
 }
 
 GrpcXdsTransportFactory::GrpcXdsTransport::~GrpcXdsTransport() {
-  grpc_channel_destroy(channel_);
+  grpc_channel_destroy_internal(channel_);
 }
 
 void GrpcXdsTransportFactory::GrpcXdsTransport::Orphan() {

tools/run_tests/sanity/core_banned_functions.py

@@ -47,6 +47,10 @@
         'src/core/lib/slice/slice.cc', 'src/core/lib/slice/slice.h'
     ],
     'grpc_call_cancel(': ['src/core/lib/surface/call.cc'],
+    'grpc_channel_destroy(': [
+        'src/core/lib/surface/channel.cc',
+        'src/core/tsi/alts/handshaker/alts_shared_resource.cc',
+    ],
     'grpc_closure_create(': [
         'src/core/lib/iomgr/closure.cc', 'src/core/lib/iomgr/closure.h'
     ],